From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [PATCH] kvm tool: rewrite kvm__init
Date: Thu, 9 Feb 2012 17:07:41 +0400
Message-ID: <20120209130741.GG5709@moon>
References: <1328766016-2644-1-git-send-email-hamo.by@gmail.com>
 <CAOJsxLFmMRoDhGk7-9H5wUYgHqf9TXQa+gVxEh1zqSVKnmF4Uw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Yang Bai <hamo.by@gmail.com>, kvm@vger.kernel.org,
	Sasha Levin <levinsasha928@gmail.com>,
	Asias He <asias.hejun@gmail.com>, Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bk0-f46.google.com ([209.85.214.46]:47340 "EHLO
	mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753291Ab2BINHs (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 9 Feb 2012 08:07:48 -0500
Received: by bkcjm19 with SMTP id jm19so1748342bkc.19
        for <kvm@vger.kernel.org>; Thu, 09 Feb 2012 05:07:47 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CAOJsxLFmMRoDhGk7-9H5wUYgHqf9TXQa+gVxEh1zqSVKnmF4Uw@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Feb 09, 2012 at 03:01:26PM +0200, Pekka Enberg wrote:
> On Thu, Feb 9, 2012 at 7:40 AM, Yang Bai <hamo.by@gmail.com> wrote:
> > Since the different issues have been handled in the
> > internal of kvm__init, it can only return NULL if error
> > happened.
> >
> > Signed-off-by: Yang Bai <hamo.by@gmail.com>
> 
> Sorry, I don't understand what this patch is attempting to fix? Why do
> you think it's better to drop the explicit error codes and always
> return NULL upon error?
> 

Yeah, I somehow don't get it as well.

	Cyrill