From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Subject: Re: [RFC] need to improve slot creation/destruction? -- Re:
 [RFC][PATCH] srcu: Implement call_srcu()
Date: Thu, 9 Feb 2012 22:48:39 +0900
Message-ID: <20120209224839.a42593552852b65f19c969ba@gmail.com>
References: <1328016724.2446.229.camel@twins>
	<4F27F0E6.1040309@redhat.com>
	<1328017807.2446.230.camel@twins>
	<20120131222447.GH2391@linux.vnet.ibm.com>
	<1328091749.2760.34.camel@laptop>
	<4F29178A.1090306@redhat.com>
	<4F2918D5.4050104@redhat.com>
	<20120201135020.GB18998@amt.cnet>
	<20120209004320.5772daa0472aef4700dab1b6@gmail.com>
	<20120208184531.GA19883@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, kvm@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yx0-f174.google.com ([209.85.213.174]:65247 "EHLO
	mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757723Ab2BINsp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 9 Feb 2012 08:48:45 -0500
Received: by yenm8 with SMTP id m8so813588yen.19
        for <kvm@vger.kernel.org>; Thu, 09 Feb 2012 05:48:44 -0800 (PST)
In-Reply-To: <20120208184531.GA19883@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 8 Feb 2012 16:45:31 -0200
Marcelo Tosatti <mtosatti@redhat.com> wrote:

> > For 3:  I think doing both "write protection" and "shadow flush" is unnecessary.
> 
> If you enable dirty logging on a slot, certainly you have to write
> protect?

When we enable dirty logging, yes.

> 
> > BTW do we really need fast slot creation/destruction?
> 
> At the moment yes. Boot a RHEL/Fedora installation disk (or any other
> guest which uses SYSLINUX splash screen) and you will see. That
> particular case is a limitation of cirrus in QEMU, ideally it should be
> optimized there.
> 

I've checked;  limiting flush to that slot seems to be good.
I will send a patch soon.

	Takuya