From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amos Kong Subject: [PATCH 4/4] net: support to include ipv6 address by brackets Date: Fri, 10 Feb 2012 14:27:28 +0800 Message-ID: <20120210062728.13397.43578.stgit@dhcp-8-167.nay.redhat.com> References: <20120210062608.13397.43361.stgit@dhcp-8-167.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com, akong@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41476 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752705Ab2BJG1W (ORCPT ); Fri, 10 Feb 2012 01:27:22 -0500 In-Reply-To: <20120210062608.13397.43361.stgit@dhcp-8-167.nay.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: That method of representing an IPv6 address with a port is discouraged because of its ambiguity. Referencing to RFC5952, the recommended format is: [2312::8274]:5200 test status: Successed listen side: qemu-kvm .... -incoming tcp:[2312::8274]:5200 client side: qemu-kvm ... (qemu) migrate -d tcp:[2312::8274]:5200 Signed-off-by: Amos Kong --- net.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 9e1ef9e..cccdb6b 100644 --- a/net.c +++ b/net.c @@ -88,6 +88,12 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep) if (!p1) return -1; len = p1 - p; + /* remove brackets which includes hostname */ + if (*p == '[' && *(p1-1) == ']') { + p += 1; + len -= 2; + } + p1++; if (buf_size > 0) { if (len > buf_size - 1)