From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: x86: kvmclock: abstract save/restore sched_clock_state Date: Fri, 10 Feb 2012 15:32:11 +0530 Message-ID: <20120210100211.GA2971@amit.redhat.com> References: <20120207210542.GC20618@amt.cnet> <20120209122742.GA25505@amit.redhat.com> <4F33E299.3090500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, johnstul@us.ibm.com, riel@redhat.com, avi@redhat.com To: Igor Mammedov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35608 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758506Ab2BJKC0 (ORCPT ); Fri, 10 Feb 2012 05:02:26 -0500 Content-Disposition: inline In-Reply-To: <4F33E299.3090500@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On (Thu) 09 Feb 2012 [16:13:29], Igor Mammedov wrote: > Stalls are probably caused by uninitialized percpu hv_clock, with > following patch I don't see stalls. Although I might be just lucky. > http://git.kernel.org/?p=virt/kvm/kvm.git;a=commit;h=e2971ac7e1d186af059e088d305496c5cb47d487 Your commit does make things better, I don't see any stalls on the first resume. However, a subsequent s4 causes the stall to re-appear on resume, and this time there are no stall messages; the kernel just sits there spinning on something. I've not found the solution to this one yet (I had a commit similar to Marcelo's in the works, which got me to the previous works-but-stalls behaviour). > However there is/are a warning/s on suspend path and with following patch: I didn't see this. Amit