From: Don Zickus <dzickus@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Sasha Levin <levinsasha928@gmail.com>,
Josh Boyer <jwboyer@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: WARNING: at arch/x86/kernel/smp.c:119 native_smp_send_reschedule+0x25/0x43()
Date: Fri, 10 Feb 2012 16:04:23 -0500 [thread overview]
Message-ID: <20120210210423.GJ5650@redhat.com> (raw)
In-Reply-To: <1328906163.25989.59.camel@laptop>
On Fri, Feb 10, 2012 at 09:36:03PM +0100, Peter Zijlstra wrote:
> On Fri, 2012-02-10 at 15:31 -0500, Don Zickus wrote:
> > So my second patch which I will eventually post will just skip the WARN_ON
> > if the system is going down. Not sure if that is the proper way to address
> > this problem or change all of the stop_this_cpu code to use a different
> > bitmask than the cpu_online bitmask (but then you run the risk of a stuck
> > IPI I guess if the cpu is halted without notifying anyone).
>
> Yeah, the async hard kill of all cpus is bound to make problems.. what
> I'm wondering is, why is this in the normal shutdown path and not
> specific to a hard panic?
I didn't write the original code, I just changed it from REBOOT_IRQ to
NMI and left all the stop_this_cpu stuff alone.
>
> Trying to make this work is just not going to be pretty, and in the
> panic case we really don't care much.
Sure.
Cheers,
Don
next prev parent reply other threads:[~2012-02-10 21:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 1:31 WARNING: at arch/x86/kernel/smp.c:119 native_smp_send_reschedule+0x25/0x43() Sasha Levin
2012-02-09 0:59 ` Josh Boyer
2012-02-09 19:46 ` Sasha Levin
2012-02-10 10:06 ` Srivatsa S. Bhat
2012-02-10 18:58 ` Peter Zijlstra
2012-02-10 19:03 ` Peter Zijlstra
2012-02-10 20:02 ` Don Zickus
2012-02-10 20:18 ` Peter Zijlstra
2012-02-10 20:31 ` Don Zickus
2012-02-10 20:36 ` Peter Zijlstra
2012-02-10 21:04 ` Don Zickus [this message]
2012-03-23 10:47 ` Sasha Levin
2012-03-23 13:26 ` Don Zickus
2012-04-05 20:38 ` Tony Luck
2012-06-01 13:36 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210210423.GJ5650@redhat.com \
--to=dzickus@redhat.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=jwboyer@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox