From: Andrea Arcangeli <aarcange@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: MMU: Flush TLBs only once in invlpg() before releasing mmu_lock
Date: Tue, 14 Feb 2012 18:21:50 +0100 [thread overview]
Message-ID: <20120214172150.GL9440@redhat.com> (raw)
In-Reply-To: <4F39E971.5020302@oss.ntt.co.jp>
On Tue, Feb 14, 2012 at 01:56:17PM +0900, Takuya Yoshikawa wrote:
> (2012/02/14 13:36), Takuya Yoshikawa wrote:
>
> > BTW, do you think that "kvm_mmu_flush_tlb()" should be moved inside of the
> > mmu_lock critical section?
> >
>
> Ah, forget about this. Trivially no.
Yes the reason is that it's the local flush and guest mode isn't
running if we're running that function so it's ok to run it later.
About the other change you did in this patch 2/2, I can't find the
code you're patching in the 3.2 upstream source, when I added the tlb
flush to invlpg, I immediately used a cumulative need_flush at the end
(before relasing mmu_lock of course).
if (need_flush)
kvm_flush_remote_tlbs(vcpu->kvm);
next prev parent reply other threads:[~2012-02-14 17:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 6:28 [PATCH 1/2] KVM: mmu_notifier: Flush TLBs before releasing mmu_lock Takuya Yoshikawa
2012-02-10 6:29 ` [PATCH 2/2] KVM: MMU: Flush TLBs only once in invlpg() " Takuya Yoshikawa
2012-02-10 6:55 ` Xiao Guangrong
2012-02-10 7:21 ` Takuya Yoshikawa
2012-02-10 7:42 ` Xiao Guangrong
2012-02-14 4:36 ` Takuya Yoshikawa
2012-02-14 4:56 ` Takuya Yoshikawa
2012-02-14 17:21 ` Andrea Arcangeli [this message]
2012-02-10 7:52 ` [PATCH 1/2] KVM: mmu_notifier: Flush TLBs " Xiao Guangrong
2012-02-13 6:00 ` Takuya Yoshikawa
2012-02-14 17:27 ` Andrea Arcangeli
2012-02-10 17:26 ` Marcelo Tosatti
2012-02-14 17:10 ` Andrea Arcangeli
2012-02-14 17:29 ` Marcelo Tosatti
2012-02-14 18:53 ` Andrea Arcangeli
2012-02-14 19:43 ` Marcelo Tosatti
2012-02-15 9:18 ` Avi Kivity
2012-02-15 9:47 ` Avi Kivity
2012-02-15 11:37 ` Xiao Guangrong
2012-02-15 14:07 ` Avi Kivity
2012-02-15 19:16 ` Andrea Arcangeli
2012-02-16 4:50 ` Xiao Guangrong
2012-02-16 11:57 ` Avi Kivity
2012-02-17 2:36 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214172150.GL9440@redhat.com \
--to=aarcange@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).