From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device Date: Mon, 20 Feb 2012 01:44:34 +0200 Message-ID: <20120219234433.GA29703@redhat.com> References: <4F3E5564.7040406@redhat.com> <20120219145707.GC16620@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Kevin Wolf , Isaku Yamahata , Avi Kivity To: Gerd Hoffmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32515 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951Ab2BSXoc (ORCPT ); Sun, 19 Feb 2012 18:44:32 -0500 Content-Disposition: inline In-Reply-To: <20120219145707.GC16620@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Feb 19, 2012 at 04:57:07PM +0200, Michael S. Tsirkin wrote: > On Fri, Feb 17, 2012 at 02:25:56PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > + /* If we don't specify the name, the bus will be addressed as .0, where > > > + * id is the parent id. But it seems more natural to address the bus using > > > + * the parent device name. */ > > > + if (dev->qdev.id && *dev->qdev.id) { > > > + br->bus_name = dev->qdev.id; > > > + } > > > > That makes the bridge behave different than everybody else. > > Not a good idea IMHO. > > > > cheers, > > Gerd > > Everybody else has names built up according to an undocumented scheme > which no one can figure out without reading code, so no one uses them. > We need to fix that, but there is, generally, no need for these names > so it stayed low priority. > > With the bridge people must use the id to connect devices to it, > so name must be a sane one. I just sent the patch making bus id for bridges follow the value set by the user. That will make the bridge behave in the same way as everybody else :) > -- > MST