[Bug 42812] New: kvm module has bogus kernel version check

[Bug 42812] New: kvm module has bogus kernel version check

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42812

           Summary: kvm module has bogus kernel version check
           Product: Virtualization
           Version: unspecified
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: kvm
        AssignedTo: virtualization_kvm@kernel-bugs.osdl.org
        ReportedBy: mcbbzko@robuust.nl
        Regression: No


In kvm-kmod-3.2, x86/external-module-compat.h, line 1102 the following check is
present:

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) || \
    (LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) && KERNEL_EXTRAVERSION < 40)

The second half is bogus, since if kernel version is 2.6.32, it would have
matched the < 2.6.37 anyway.
Maybe the 2,6,32 should read 2,6,37 instead? (that would make more sense, but
may not be right!)

This check appears to be present since kvm-kmod release 3.0b, which makes it
unlikely many people tried it with 2.6.27.40+ kernels and found it to be a
problem...

--
Maarten

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 42812] kvm module has bogus kernel version check

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42812


Jan Kiszka <jan.kiszka@web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kiszka@web.de




--- Comment #1 from Jan Kiszka <jan.kiszka@web.de>  2012-02-28 17:29:13 ---
Thanks for reporting, addressed in latest kvm-kmod.git.

Jan

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 42812] kvm module has bogus kernel version check

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42812


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 42812] kvm module has bogus kernel version check

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=42812


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.