From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH 4/4 v3] KVM: Introduce kvm_memory_slot::arch and move lpage_info into it Date: Wed, 7 Mar 2012 23:15:56 +0900 Message-ID: <20120307231556.695b3b71bcfea653d6cc2a5c@gmail.com> References: <20120130124859.6c3bb19f.yoshikawa.takuya@oss.ntt.co.jp> <20120130125308.51e22f12.yoshikawa.takuya@oss.ntt.co.jp> <20120130143533.e52efcbe.yoshikawa.takuya@oss.ntt.co.jp> <4F274144.9000606@oss.ntt.co.jp> <065A8746-BEDD-4E2B-8AAB-FDA26D496582@suse.de> <20120307134617.f7fa887c.yoshikawa.takuya@oss.ntt.co.jp> <4F576247.4010402@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Takuya Yoshikawa , avi@redhat.com, mtosatti@redhat.com, kvm@vger.kernel.org, cotte@de.ibm.com, Paul Mackerras , borntraeger@de.ibm.com, Andrea Arcangeli To: Alexander Graf Return-path: Received: from mail-tul01m020-f174.google.com ([209.85.214.174]:46338 "EHLO mail-tul01m020-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756815Ab2CGOQD (ORCPT ); Wed, 7 Mar 2012 09:16:03 -0500 Received: by obbuo6 with SMTP id uo6so6961058obb.19 for ; Wed, 07 Mar 2012 06:16:02 -0800 (PST) In-Reply-To: <4F576247.4010402@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > > IMO rmap also should to be moved into the arch. > > s390 does not need it and other architectures than x86 will be happy if > > the type of it can be changed from unsigned long to a pointer, no? > > How would an unsigned long make a difference over a pointer? Not so much. Just a matter of casting. x86 is using the least significant bit for special encoding, so unsigned long is natural. My initial motivation was to make rmap multi-dimensional so that it can also hold rmap_pde. Takuya