From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christoffer Dall <c.dall@virtualopensystems.com>
Cc: Alexander Graf <agraf@suse.de>,
KVM devel mailing list <kvm@vger.kernel.org>,
tech@virtualopensystems.com,
android-virt <android-virt@lists.cs.columbia.edu>,
kvm-ppc <kvm-ppc@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH v4] KVM: Factor out kvm_vcpu_kick to arch-generic code
Date: Fri, 9 Mar 2012 21:09:59 -0300 [thread overview]
Message-ID: <20120310000959.GA27276@amt.cnet> (raw)
In-Reply-To: <CANM98qJXzw+4aLnHFgzYTr-=qH95HpM_sbg7gBdZzXx2XvmM_g@mail.gmail.com>
On Thu, Mar 08, 2012 at 04:44:24PM -0500, Christoffer Dall wrote:
> Any news on the status of this?
>
> On Thu, Feb 9, 2012 at 8:45 PM, Alexander Graf <agraf@suse.de> wrote:
> >
> > On 10.02.2012, at 02:40, Christoffer Dall wrote:
> >
> >> The kvm_vcpu_kick function performs roughly the same funcitonality on
> >> most all architectures, so we shouldn't have separate copies.
> >>
> >> PowerPC keeps a pointer to interchanging waitqueues on the vcpu_arch
> >> structure and to accomodate this special need a
> >> __KVM_HAVE_ARCH_VCPU_GET_WQ define and accompanying function
> >> kvm_arch_vcpu_wq have been defined. For all other architectures this
> >> is a generic inline that just returns &vcpu->wq;
> >>
> >> This patch applies to d1c28f7568a74faacec896ee4f84afbffd20e5ab on
> >> git://git.kernel.org/pub/scm/virt/kvm/kvm.git.
> >>
> >> Changes since v3:
> >> - Doesn't try to generalize vcpu->mode across all architectures and
> >> instead calls kvm_arch_vcpu_should_kick, which is properly defined
> >> on x86 and ia64, but other architectures simply return 1 as to maintain
> >> status quo.
> >>
> >> Changes since v2:
> >> - Restore arch-specific vcpu->cpu assignment to arch-specific code
> >>
> >> Changes since v1:
> >> - Abstact CPU mode check into arch-specific function
> >> - Remove redundant vcpu->cpu assignment
> >>
> >> Signed-off-by: Christoffer Dall <c.dall@virtualopensystems.com>
Applied, thanks.
next prev parent reply other threads:[~2012-03-10 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 1:40 [PATCH v4] KVM: Factor out kvm_vcpu_kick to arch-generic code Christoffer Dall
2012-02-10 1:45 ` Alexander Graf
2012-02-10 1:49 ` Christoffer Dall
2012-03-08 21:44 ` Christoffer Dall
2012-03-08 21:51 ` Scott Wood
2012-03-10 0:09 ` Marcelo Tosatti [this message]
2012-03-13 20:34 ` Alexander Graf
2012-03-13 20:47 ` [Android-virt] " Christoffer Dall
2012-03-13 20:48 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120310000959.GA27276@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=android-virt@lists.cs.columbia.edu \
--cc=c.dall@virtualopensystems.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox