From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v4] KVM: Factor out kvm_vcpu_kick to arch-generic code Date: Fri, 9 Mar 2012 21:09:59 -0300 Message-ID: <20120310000959.GA27276@amt.cnet> References: <20120210014013.16869.20143.stgit@ubuntu> <1605556A-F833-4B38-8BEF-BCB584F2C8D2@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Graf , KVM devel mailing list , tech@virtualopensystems.com, android-virt , kvm-ppc , Paul Mackerras , Scott Wood To: Christoffer Dall Return-path: Content-Disposition: inline In-Reply-To: Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Mar 08, 2012 at 04:44:24PM -0500, Christoffer Dall wrote: > Any news on the status of this? >=20 > On Thu, Feb 9, 2012 at 8:45 PM, Alexander Graf wrote: > > > > On 10.02.2012, at 02:40, Christoffer Dall wrote: > > > >> The kvm_vcpu_kick function performs roughly the same funcitonality= on > >> most all architectures, so we shouldn't have separate copies. > >> > >> PowerPC keeps a pointer to interchanging waitqueues on the vcpu_ar= ch > >> structure and to accomodate this special need a > >> __KVM_HAVE_ARCH_VCPU_GET_WQ define and accompanying function > >> kvm_arch_vcpu_wq have been defined. For all other architectures th= is > >> is a generic inline that just returns &vcpu->wq; > >> > >> This patch applies to d1c28f7568a74faacec896ee4f84afbffd20e5ab on > >> git://git.kernel.org/pub/scm/virt/kvm/kvm.git. > >> > >> Changes since v3: > >> - Doesn't try to generalize vcpu->mode across all architectures an= d > >> =A0 instead calls kvm_arch_vcpu_should_kick, which is properly def= ined > >> =A0 on x86 and ia64, but other architectures simply return 1 as to= maintain > >> =A0 status quo. > >> > >> Changes since v2: > >> - Restore arch-specific vcpu->cpu assignment to arch-specific code > >> > >> Changes since v1: > >> - Abstact CPU mode check into arch-specific function > >> - Remove redundant vcpu->cpu assignment > >> > >> Signed-off-by: Christoffer Dall Applied, thanks.