From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] KVM: PPC: Rework wqp conditional code Date: Tue, 13 Mar 2012 20:50:35 -0300 Message-ID: <20120313235035.GB15362@amt.cnet> References: <1331674501-12631-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Christoffer Dall To: Alexander Graf Return-path: Content-Disposition: inline In-Reply-To: <1331674501-12631-1-git-send-email-agraf@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Mar 13, 2012 at 10:35:01PM +0100, Alexander Graf wrote: > On PowerPC, we sometimes use a waitqueue per core, not per thread, > so we can't always use the vcpu internal waitqueue. > > This code has been generalized by Christoffer Dall recently, but > unfortunately broke compilation for PowerPC. At the time the helper > function is defined, struct kvm_vcpu is not declared yet, so we can't > dereference it. > > This patch moves all logic into the generic inline function, at which > time we have all information necessary. > > Signed-off-by: Alexander Graf Applied, thanks.