From: Nadav Har'El <nyh@math.technion.ac.il>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Julian Stecklina <js@alien8.de>
Subject: Re: PATCH: nVMX: Better MSR_IA32_FEATURE_CONTROL handling
Date: Thu, 15 Mar 2012 19:40:14 +0200 [thread overview]
Message-ID: <20120315174014.GA21487@fermat.math.technion.ac.il> (raw)
In-Reply-To: <4F578A53.20809@redhat.com>
On Wed, Mar 07, 2012, Avi Kivity wrote about "Re: PATCH: nVMX: Better MSR_IA32_FEATURE_CONTROL handling":
> > struct page *apic_access_page;
> > + u64 msr_ia32_feature_control;
> > };
>...
> (msrs_to_save). The variable itself should live in vcpu->arch, even if
> some bits are vendor specific.
Does this MSR exist in AMD? I was under the impression that it is an
Intel-only MSR, and that AMD has something different, the VM_CR MSR,
so it didn't make sense to put this in vcpu->arch. Is my impression
wrong?
I seems, by the way, that svm.c has vm_cr_msr in svm->nested, basically the
same what I did, not in vcpu->arch. Why is this bad?
Also, it seems that VM_CR is also not on the list on msrs_to_save.
A bug?
> > @@ -1999,7 +2000,7 @@ static int vmx_get_vmx_msr(struct kvm_vc
> >
> > switch (msr_index) {
> > case MSR_IA32_FEATURE_CONTROL:
> > - *pdata = 0;
> > + *pdata = to_vmx(vcpu)->nested.msr_ia32_feature_control;
> > break;
>
> In a separate patch, please move this outside vmx_get_vmx_msr(). It's
> not a vmx msr.
I agree, I'll move it. But if it's a VMX-only MSR, I want to leave it
in vmx.c, and not move it to x86.c.
--
Nadav Har'El | Thursday, Mar 15 2012,
nyh@math.technion.ac.il |-----------------------------------------
Phone +972-523-790466, ICQ 13349191 |If I am not for myself, who will be for
http://nadav.harel.org.il |me? If I am only for myself, who am I?
next prev parent reply other threads:[~2012-03-15 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 15:58 PATCH: nVMX: Better MSR_IA32_FEATURE_CONTROL handling Nadav Har'El
2012-03-07 16:18 ` Avi Kivity
2012-03-15 17:40 ` Nadav Har'El [this message]
2012-03-15 18:08 ` Avi Kivity
2012-03-19 16:53 ` Nadav Har'El
2012-03-19 17:03 ` Nadav Har'El
2012-03-21 13:09 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315174014.GA21487@fermat.math.technion.ac.il \
--to=nyh@math.technion.ac.il \
--cc=avi@redhat.com \
--cc=js@alien8.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox