From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC][PATCH v2 0/4] uq/master: Basic MSI support for in-kernel irqchip mode Date: Wed, 4 Apr 2012 11:39:28 +0300 Message-ID: <20120404083927.GC3003@redhat.com> References: <20120403130604.GA11053@redhat.com> <4F7B3308.5060700@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25127 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755312Ab2DDIjQ (ORCPT ); Wed, 4 Apr 2012 04:39:16 -0400 Content-Disposition: inline In-Reply-To: <4F7B3308.5060700@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Apr 03, 2012 at 07:27:36PM +0200, Jan Kiszka wrote: > On 2012-04-03 15:06, Michael S. Tsirkin wrote: > > On Tue, Apr 03, 2012 at 09:23:12AM +0200, Jan Kiszka wrote: > >> This is v2 of the RFC, fixing a memory leak in > >> kvm_flush_dynamic_msi_routes and adding support for the proposed > >> KVM_SIGNAL_MSI IOCTL. > >> > >> This series depends on "kvm: set gsi_bits and max_gsi correctly" > >> (http://thread.gmane.org/gmane.comp.emulators.kvm.devel/88906). > > > > Looks good to me. > > How hard would it be to add irqfd support? > > Shouldn't be, but the changes will be a bit bigger. > > I'm thinking about a revamped interface between the MSI core and > affected devices for a while. Will try to put down in some lines of code > what I have in mind - once the dynamic MSI injection topic has settled. > > Jan Yes it's not an objection - just a question. > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux