From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v4] KVM: Introduce direct MSI message injection for
 in-kernel irqchips
Date: Wed, 4 Apr 2012 11:53:59 +0300
Message-ID: <20120404085359.GA3404@redhat.com>
References: <4F734EB3.20500@siemens.com>
 <4F748AAD.2040103@siemens.com>
 <4F74B484.30607@siemens.com>
 <4F7B24EA.2070300@redhat.com>
 <4F7B29B5.6060703@siemens.com>
 <20120404083821.GB3003@redhat.com>
 <4F7C09E7.3020005@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm <kvm@vger.kernel.org>, Eric Northup <digitaleric@google.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:11598 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751447Ab2DDIxq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 Apr 2012 04:53:46 -0400
Content-Disposition: inline
In-Reply-To: <4F7C09E7.3020005@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Apr 04, 2012 at 11:44:23AM +0300, Avi Kivity wrote:
> On 04/04/2012 11:38 AM, Michael S. Tsirkin wrote:
> > > 
> > > > 
> > > > A performance note: delivering an interrupt needs to search all vcpus
> > > > for an APIC ID match.  The previous plan was to cache (or pre-calculate)
> > > > this lookup in the irq routing table.  Now it looks like we'll need a
> > > > separate cache for this.
> > > 
> > > As this is non-existent until today, we don't regress here. And it can
> > > still be added on top later on, transparently.
> >
> > I always worry about hash collisions and the cost of
> > calculating good hash functions.
> >
> > We could instead return an index in the cache on injection, maintain in
> > userspace and use it for fast path on the next injection.
> 
> Ahem, that is almost the existing routing table to a T.
> 
> > Will make it easy to use an array index instead of a hash here,
> > and fallback to a slower ID lookup on mismatch.
> 
> Need a free ioctl so we can reuse IDs.

No, it could be kernel controlled not userspace controlled. We get both
and address and an index:

if (table[u.i].addr == u.addr && table[u.i].data == u.data) {
	return table[u.i].id;
}

u.i = find_lru_idx(&table);
table[u.i].addr = u.addr;
table[u.i].data = u.data;
table[u.i].id = find_id(u.addr, u.data);
return table[u.i].id;


> > Until we do have this fast path we can just fill this value with zeros,
> > so kernel patch (almost) does not need to change for this -
> > just the header.
> 
> Partially implemented interfaces invite breakage.

Hmm true. OK scrap this idea then, it's not clear
whether we are going to optimize this anyway.

> 
> -- 
> I have a truly marvellous patch that fixes the bug which this
> signature is too narrow to contain.