From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2] kvm: Disable MSI/MSI-X in assigned device reset path Date: Thu, 5 Apr 2012 18:04:23 +0300 Message-ID: <20120405150422.GA1089@redhat.com> References: <20120405033450.25661.68810.stgit@bling.home> <20120405093415.GC28229@redhat.com> <1333636923.2427.13.camel@ul30vt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, jan.kiszka@siemens.com, jbaron@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:23976 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754531Ab2DEPEL (ORCPT ); Thu, 5 Apr 2012 11:04:11 -0400 Content-Disposition: inline In-Reply-To: <1333636923.2427.13.camel@ul30vt> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Apr 05, 2012 at 08:42:03AM -0600, Alex Williamson wrote: > > So far so good. > > > > > + * We especially do not want MSI-X > > > + * enabled since it lives in MMIO space, which is about to get > > > + * disabled. > > > > I think we are better off dropping the above, because it's > > a bug that we disable MMIO space on the physical device: > > we did not enable it (kvm did) let's not disable. > > I'd like to investigate removing the command register clearing, but it > did solve a bug at the time it went in. That will be a separate patch, > so we can remove the above sentence when that's removed. It may be a > bug, but it's describing the current behavior. Fair enough. Acked-by: Michael S. Tsirkin