From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2] kvm: Disable MSI/MSI-X in assigned device reset path Date: Sun, 8 Apr 2012 16:30:16 +0300 Message-ID: <20120408133016.GA14136@redhat.com> References: <20120405033450.25661.68810.stgit@bling.home> <4F818F35.7010905@redhat.com> <20120408131710.GA13997@redhat.com> <4F819025.30407@redhat.com> <20120408132126.GD13997@redhat.com> <4F81917B.5050805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alex Williamson , kvm@vger.kernel.org, jan.kiszka@siemens.com, jbaron@redhat.com To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64727 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755350Ab2DHNaD (ORCPT ); Sun, 8 Apr 2012 09:30:03 -0400 Content-Disposition: inline In-Reply-To: <4F81917B.5050805@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Apr 08, 2012 at 04:24:11PM +0300, Avi Kivity wrote: > On 04/08/2012 04:21 PM, Michael S. Tsirkin wrote: > > On Sun, Apr 08, 2012 at 04:18:29PM +0300, Avi Kivity wrote: > > > On 04/08/2012 04:17 PM, Michael S. Tsirkin wrote: > > > > > > > > > > Don't we FLR the device, which ought to disable MSI on the real device? > > > > > > > > AFAIK we call pci_reset, which saves device state, does an FLR > > > > and then restores the state. I think this might include msi as well. > > > > > > > > > > > > > > Then that is wrong as well, no? > > > > Not as such assuming we disable msi/msix first :) > > I think we need to fix both, no? Isn't this what this patch does? > -- > error compiling committee.c: too many arguments to function