From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: zhangyanfei <zhangyanfei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
luto-3s7WtUTddSA@public.gmane.org,
gregkh-l3A5Bk7waGM@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joerg.roedel-5C7GfCeVMHo@public.gmane.org,
mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org,
ludwig.nussel-l3A5Bk7waGM@public.gmane.org,
avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs
Date: Thu, 12 Apr 2012 16:00:58 -0700 [thread overview]
Message-ID: <20120412230058.GA23292@kroah.com> (raw)
In-Reply-To: <4F84E50E.2090008-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote:
> This patch creates sysfs file to export where VMCSINFO is allocated,
> as below:
> $ cat /sys/kernel/vmcsinfo
> 1cb88a0 2000
> number on the left-hand side is the physical address of VMCSINFO,
> while the one on the right-hand side is the max size of VMCSINFO.
Ick, why do you have 2 values in one sysfs file, that's not nice, or
good.
What's wrong with 2 different files?
Also, any new sysfs file you add needs to also have a Documentation/ABI
entry added as well.
But we can't accept this as-is, sorry, please split it up into 2 files.
greg k-h
next prev parent reply other threads:[~2012-04-12 23:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 1:39 [PATCH 0/4] Export offsets of VMCS fields as note information for kdump zhangyanfei
2012-04-11 1:49 ` [PATCH 1/4] x86: Add helper variables and functions to hold VMCSINFO zhangyanfei
2012-04-11 1:50 ` [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO zhangyanfei
[not found] ` <4F84E365.10201-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-11 8:48 ` Avi Kivity
[not found] ` <4F85454E.6020201-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-11 10:34 ` zhangyanfei
[not found] ` <4F855E3C.9010003-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-11 11:41 ` Avi Kivity
[not found] ` <4F84E0DF.8040206-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-11 1:57 ` [PATCH 3/4] ksysfs: export VMCSINFO via sysfs zhangyanfei
[not found] ` <4F84E50E.2090008-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-12 23:00 ` Greg KH [this message]
2012-04-17 1:52 ` zhangyanfei
2012-04-17 2:30 ` Greg KH
2012-04-11 1:58 ` [PATCH 4/4] kexec: Add crash_save_vmcsinfo to update VMCSINFO zhangyanfei
2012-04-11 10:21 ` [PATCH 0/4] Export offsets of VMCS fields as note information for kdump Joerg Roedel
[not found] ` <20120411102136.GG2428-5C7GfCeVMHo@public.gmane.org>
2012-04-11 10:49 ` Avi Kivity
2012-04-11 10:59 ` zhangyanfei
2012-04-17 7:44 ` Avi Kivity
[not found] ` <4F8D1F46.3090901-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-17 10:51 ` zhangyanfei
[not found] ` <4F8D4B4C.8070705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-17 10:59 ` Avi Kivity
[not found] ` <4F8D4D1C.4010400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-17 11:25 ` Wen Congyang
[not found] ` <4F8D530C.3050908-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-17 13:04 ` Avi Kivity
2012-04-18 7:30 ` zhangyanfei
[not found] ` <4F8E6DA5.8030503-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-18 8:24 ` Avi Kivity
[not found] ` <4F8E7A5B.5030904-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-18 9:49 ` zhangyanfei
[not found] ` <4F8E8E3D.8040707-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-04-18 11:56 ` Avi Kivity
[not found] ` <4F8EABF7.805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-19 10:36 ` HATAYAMA Daisuke
[not found] ` <20120419.193640.59653378.d.hatayama-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-19 10:42 ` Avi Kivity
[not found] ` <4F8FEC22.400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-19 11:27 ` HATAYAMA Daisuke
[not found] ` <20120419.202707.276752866.d.hatayama-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-19 11:31 ` Avi Kivity
[not found] ` <4F8FF7AC.1060309-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-19 12:01 ` HATAYAMA Daisuke
[not found] ` <20120419.210119.246504497.d.hatayama-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-19 12:08 ` Avi Kivity
[not found] ` <4F900020.5010702-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-20 10:11 ` HATAYAMA Daisuke
2012-04-22 9:58 ` Avi Kivity
[not found] ` <4F93D64B.50803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-22 10:33 ` Gleb Natapov
[not found] ` <20120422103340.GE12768-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-22 10:57 ` Avi Kivity
2012-04-17 16:49 ` Anthony Liguori
[not found] ` <4F8D9F20.9050507-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2012-04-18 12:13 ` Avi Kivity
2012-04-18 13:47 ` Nadav Har'El
[not found] ` <20120418134743.GA25786-QeE623+hzFJ/hwrKWqB9+zWi1Rwp9Q0N+oGz7xIJsNs@public.gmane.org>
2012-04-18 14:06 ` Avi Kivity
2012-04-11 8:56 ` Avi Kivity
[not found] ` <4F85472A.4080009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-11 10:12 ` zhangyanfei
2012-04-11 11:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412230058.GA23292@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=joerg.roedel-5C7GfCeVMHo@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludwig.nussel-l3A5Bk7waGM@public.gmane.org \
--cc=luto-3s7WtUTddSA@public.gmane.org \
--cc=mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
--cc=zhangyanfei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox