From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: kvm: RCU warning in async pf Date: Mon, 16 Apr 2012 16:08:06 +0300 Message-ID: <20120416130806.GV11918@redhat.com> References: <1333414472.11455.7.camel@lappy> <20120403105226.GF14939@redhat.com> <20120404123033.GD11918@redhat.com> <1334396693.2528.45.camel@twins> <20120416102855.GP11918@redhat.com> <20120416125848.GT11918@redhat.com> <1334581548.28150.40.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sasha Levin , Avi Kivity , Marcelo Tosatti , Thomas Gleixner , Ingo Molnar , "Paul E. McKenney" , kvm , linux-kernel , Dave Jones To: Peter Zijlstra Return-path: Content-Disposition: inline In-Reply-To: <1334581548.28150.40.camel@twins> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote: > On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote: > > - rcu_irq_enter(); > > + irq_enter(); > > exit_idle(); > > Do we really need the exit_idle()? I can't remember other interrupt > handlers doing that. They do. That's where I got the idea. -- Gleb.