From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCHv2] device-assignment: don't touch real command register
Date: Tue, 17 Apr 2012 15:00:37 +0300
Message-ID: <20120417120037.GA23957@redhat.com>
References: <20120416195327.GA30402@redhat.com>
 <4F8D52E8.8080403@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:12869 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932225Ab2DQMwc (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 17 Apr 2012 08:52:32 -0400
Content-Disposition: inline
In-Reply-To: <4F8D52E8.8080403@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Apr 17, 2012 at 01:24:24PM +0200, Jan Kiszka wrote:
> > +    /* Pass bus master writes to device. */
> > +    pci_dev->emulate_config_write[PCI_COMMAND] &= ~PCI_COMMAND_MASTER;
> > +    pci_dev->emulate_config_write[PCI_COMMAND + 1] &= ~(PCI_COMMAND_INTX_DISABLE >> 8);
> 
> Comment doesn't fully match the code.

Will fix.

> And I bet you aren't using
> checkpatch... ;)

I didn't run it but it doesn't complain.