From: Marcelo Tosatti <mtosatti@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
jbaron@redhat.com, jan.kiszka@siemens.com
Subject: Re: [PATCH] kvm: lock slots_lock around device assignment
Date: Thu, 19 Apr 2012 00:04:32 -0300 [thread overview]
Message-ID: <20120419030432.GA23261@amt.cnet> (raw)
In-Reply-To: <20120418034537.26262.80743.stgit@bling.home>
On Tue, Apr 17, 2012 at 09:46:44PM -0600, Alex Williamson wrote:
> As pointed out by Jason Baron, when assigning a device to a guest
> we first set the iommu domain pointer, which enables mapping
> and unmapping of memory slots to the iommu. This leaves a window
> where this path is enabled, but we haven't synchronized the iommu
> mappings to the existing memory slots. Thus a slot being removed
> at that point could send us down unexpected code paths removing
> non-existent pinnings and iommu mappings. Take the slots_lock
> around creating the iommu domain and initial mappings as well as
> around iommu teardown to avoid this race.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2012-04-19 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 3:46 [PATCH] kvm: lock slots_lock around device assignment Alex Williamson
2012-04-19 2:30 ` Marcelo Tosatti
2012-04-19 2:58 ` Alex Williamson
2012-04-19 3:04 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419030432.GA23261@amt.cnet \
--to=mtosatti@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jbaron@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox