From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [RFC PATCH 0/9] ACPI memory hotplug
Date: Sun, 22 Apr 2012 17:20:59 +0300
Message-ID: <20120422142059.GD15413@redhat.com>
References: <1334844527-18869-1-git-send-email-vasilis.liaskovitis@profitbricks.com>
	<20120422135618.GA15413@redhat.com> <4F941073.8090702@redhat.com>
	<20120422140945.GC15413@redhat.com> <4F941207.6050508@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>,
	seabios@seabios.org, qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
Content-Disposition: inline
In-Reply-To: <4F941207.6050508@redhat.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote:
> On 04/22/2012 05:09 PM, Gleb Natapov wrote:
> > On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi Kivity wrote:
> > > On 04/22/2012 04:56 PM, Gleb Natapov wrote:
> > > > start. We will need it for migration anyway.
> > > >
> > > > > hotplug-able memory slots i.e. initial system memory is not modeled with
> > > > > memslots. The concept could be generalized to include all memory though, or it
> > > > > could more closely follow kvm-memory slots.
> > > > OK, I hope final version will allow for memory < 4G to be hot-pluggable.
> > > 
> > > Why is that important?
> > > 
> > Because my feeling is that people that want to use this kind of feature
> > what to start using it with VMs smaller than 4G. Of course not all
> > memory have to be hot unpluggable. Making first 1M or event first 128M not
> > unpluggable make perfect sense.
> 
> Can't you achieve this with -m 1G, -device dimm,size=1G,populated=true
> -device dimm,size=1G,populated=false?
> 
>>From this:

(for hw/pc.c PCI hole is currently [below_4g_mem_size, 4G), so
hotplugged memory should start from max(4G, above_4g_mem_size).

I understand that hotpluggable memory can start from above 4G only. With
the config above we will have memory hole from 1G to PCI memory hole.
May be not a big problem, but I do not see technical reason for the constrain.
 
> (I don't think hotplugging below 512MB is needed, but I don't have any
> real data on this).
> 
512MB looks like a reasonable limitation too, but again if there is not
technical reason for having the limitation why have it?

--
			Gleb.