public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp
Subject: Re: [PATCH 1/1 v2] KVM: Reduce mmu_lock contention during dirty logging by cond_resched()
Date: Mon, 30 Apr 2012 00:13:30 +0900	[thread overview]
Message-ID: <20120430001330.00ae231245771e482ec9977a@gmail.com> (raw)
In-Reply-To: <4F9D5773.4090505@redhat.com>

On Sun, 29 Apr 2012 18:00:03 +0300
Avi Kivity <avi@redhat.com> wrote:

> > After your work, 8192 in my patch may better be lowered a bit.
> >
> 
> Why not remove it altogether?  Just change it to cond_resched_lock().

Two concerns:

	- too many checks may slow down GET_DIRTY_LOG.
	- cond_resched_lock() uses spin_needbreak(), and I am not sure if
	  this still does rescheduling for alleviating mmu_lock contention
	  without CONFIG_PREEMPT.

I need to read the code a bit more.

Thanks,
	Takuya

  reply	other threads:[~2012-04-29 15:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-28 10:05 [PATCH 0/1 v2] KVM: Alleviate mmu_lock contention during dirty logging Takuya Yoshikawa
2012-04-28 10:07 ` [PATCH 1/1 v2] KVM: Reduce mmu_lock contention during dirty logging by cond_resched() Takuya Yoshikawa
2012-04-29 11:27   ` Avi Kivity
2012-04-29 12:17     ` Takuya Yoshikawa
2012-04-29 12:59       ` Avi Kivity
2012-04-29 14:24         ` Takuya Yoshikawa
2012-04-29 14:39           ` Avi Kivity
2012-04-29 14:55             ` Takuya Yoshikawa
2012-04-29 15:00               ` Avi Kivity
2012-04-29 15:13                 ` Takuya Yoshikawa [this message]
2012-04-29 15:20                   ` Avi Kivity
2012-04-30 14:06                     ` Takuya Yoshikawa
2012-05-01  3:04               ` Marcelo Tosatti
2012-05-01 13:14                 ` Takuya Yoshikawa
2012-05-01  3:07             ` Marcelo Tosatti
2012-05-02 11:24 ` Heavy memory_region_get_dirty() -- Re: [PATCH 0/1 v2] KVM: Alleviate mmu_lock contention during dirty logging Takuya Yoshikawa
2012-05-02 11:33   ` Avi Kivity
2012-05-02 14:20     ` Takuya Yoshikawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120430001330.00ae231245771e482ec9977a@gmail.com \
    --to=takuya.yoshikawa@gmail.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox