From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Subject: Re: [PATCH 1/1 v2] KVM: Reduce mmu_lock contention during dirty
 logging by cond_resched()
Date: Mon, 30 Apr 2012 00:13:30 +0900
Message-ID: <20120430001330.00ae231245771e482ec9977a@gmail.com>
References: <20120428190544.7dc2bfd281054c1fcac5a14e@gmail.com>
	<20120428190754.5c27325da5663e5d8c9b9be1@gmail.com>
	<4F9D25A2.7020303@redhat.com>
	<20120429211759.0265df80d7193048344ff35b@gmail.com>
	<4F9D3B26.7090602@redhat.com>
	<20120429232407.684da454a0862f121754a126@gmail.com>
	<4F9D52A7.8020105@redhat.com>
	<20120429235550.856ff62eff954caf9ea739b5@gmail.com>
	<4F9D5773.4090505@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
	yoshikawa.takuya@oss.ntt.co.jp
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pb0-f46.google.com ([209.85.160.46]:36524 "EHLO
	mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753939Ab2D2PNf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 29 Apr 2012 11:13:35 -0400
Received: by pbbrp8 with SMTP id rp8so2404699pbb.19
        for <kvm@vger.kernel.org>; Sun, 29 Apr 2012 08:13:35 -0700 (PDT)
In-Reply-To: <4F9D5773.4090505@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 29 Apr 2012 18:00:03 +0300
Avi Kivity <avi@redhat.com> wrote:

> > After your work, 8192 in my patch may better be lowered a bit.
> >
> 
> Why not remove it altogether?  Just change it to cond_resched_lock().

Two concerns:

	- too many checks may slow down GET_DIRTY_LOG.
	- cond_resched_lock() uses spin_needbreak(), and I am not sure if
	  this still does rescheduling for alleviating mmu_lock contention
	  without CONFIG_PREEMPT.

I need to read the code a bit more.

Thanks,
	Takuya