From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH 2/2] Provide fast path for "rep ins" emulation if possible. Date: Thu, 24 May 2012 12:54:03 +0200 Message-ID: <20120524105403.GL2604@amd.com> References: <1337782095-32287-1-git-send-email-gleb@redhat.com> <1337782095-32287-3-git-send-email-gleb@redhat.com> <4FBCF6EB.8040604@redhat.com> <4FBCF8FB.6050308@redhat.com> <20120524103457.GK2604@amd.com> <4FBE0F43.4060408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Gleb Natapov , , To: Avi Kivity Return-path: Received: from va3ehsobe010.messaging.microsoft.com ([216.32.180.30]:36242 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755526Ab2EXKyI (ORCPT ); Thu, 24 May 2012 06:54:08 -0400 Content-Disposition: inline In-Reply-To: <4FBE0F43.4060408@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 24, 2012 at 01:36:51PM +0300, Avi Kivity wrote: > On 05/24/2012 01:34 PM, Roedel, Joerg wrote: > > On Wed, May 23, 2012 at 05:49:31PM +0300, Avi Kivity wrote: > >> On 05/23/2012 05:40 PM, Avi Kivity wrote: > >> > On 05/23/2012 05:08 PM, Gleb Natapov wrote: > >> > If decode assists are not available, we still need to emulate, see 15.33.5. > >> > > >> > >> Joerg, the 2010 version of the manual says that the effective segment > >> (10:12) is only available with decode assists. The 2012 version says > >> it's unconditional. What's correct? > > > > It is still conditional and only available with decode-assists. I will > > talk to the APM authors to clarify this in the documentation. > > Thanks. As it happens it doesn't matter for INS emulation, only OUTS, > unless other bits in that word also depend on decode assists. Doesn't look like it. All other bits EXITINFO1 bits for the IOIO intercept are documented from the very ancient beginnings of SVM. So the segment number is the only addition. Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632