From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH] KVM: MMU: fix huge page adapted on non-PAE host
Date: Mon, 28 May 2012 16:44:39 +0200
Message-ID: <20120528144439.GH4016@redhat.com>
References: <4FC316E3.6080607@linux.vnet.ibm.com>
 <4FC35A15.6080000@redhat.com>
 <4FC363EE.6060204@linux.vnet.ibm.com>
 <4FC36E85.4010909@redhat.com>
 <4FC37600.1060301@linux.vnet.ibm.com>
 <4FC37A18.10809@redhat.com>
 <4FC38084.40409@linux.vnet.ibm.com>
 <4FC38362.6010802@redhat.com>
 <20120528143221.GF4016@redhat.com>
 <4FC38E48.9080701@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <4FC38E48.9080701@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Mon, May 28, 2012 at 05:40:08PM +0300, Avi Kivity wrote:
> Yes, I see it now.  Adjusting mask is incorrect since we won't have the
> same adjustment on release.  I'll apply the patch for 3.5.

Sounds great to me. One thing I'm not sure about is about the real need of
the mmio check vs a stright get_page (we shouldn't ever get to a gup-fast
succeeding if this was a mmio region?) but I don't see chances that it
could hurt either.

Thanks!
Andrea