From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] kvm: document lapic regs field
Date: Fri, 1 Jun 2012 19:34:04 -0300 [thread overview]
Message-ID: <20120601223404.GA4481@amt.cnet> (raw)
In-Reply-To: <20120523161613.GA31296@redhat.com>
On Wed, May 23, 2012 at 07:16:14PM +0300, Michael S. Tsirkin wrote:
> The logic in find_highest_vector looks
> strange until you realize the reason for the
> weird memory layout, which is because this is
> what the CPU microcode expects.
>
> Add a comment so this stops tripping people up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> arch/x86/kvm/lapic.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kvm/lapic.h b/arch/x86/kvm/lapic.h
> index 41c62c7..1d1ec08 100644
> --- a/arch/x86/kvm/lapic.h
> +++ b/arch/x86/kvm/lapic.h
> @@ -15,6 +15,11 @@ struct kvm_lapic {
> bool irr_pending;
> s16 isr_count;
> int isr_cache;
Wrong branch.
prev parent reply other threads:[~2012-06-01 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 16:16 [PATCH] kvm: document lapic regs field Michael S. Tsirkin
2012-06-01 22:34 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601223404.GA4481@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox