From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] kvm: document lapic regs field
Date: Fri, 1 Jun 2012 19:34:04 -0300
Message-ID: <20120601223404.GA4481@amt.cnet>
References: <20120523161613.GA31296@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:11850 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S966034Ab2FAXxH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 1 Jun 2012 19:53:07 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q51Nr6Wg012571
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Fri, 1 Jun 2012 19:53:06 -0400
Content-Disposition: inline
In-Reply-To: <20120523161613.GA31296@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, May 23, 2012 at 07:16:14PM +0300, Michael S. Tsirkin wrote:
> The logic in find_highest_vector looks
> strange until you realize the reason for the
> weird memory layout, which is because this is
> what the CPU microcode expects.
> 
> Add a comment so this stops tripping people up.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  arch/x86/kvm/lapic.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kvm/lapic.h b/arch/x86/kvm/lapic.h
> index 41c62c7..1d1ec08 100644
> --- a/arch/x86/kvm/lapic.h
> +++ b/arch/x86/kvm/lapic.h
> @@ -15,6 +15,11 @@ struct kvm_lapic {
>  	bool irr_pending;
>  	s16 isr_count;
>  	int isr_cache;

Wrong branch.