From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 1/3 - qemu-kvm stable-1.0] Fix conditional build of various x86 specific bits Date: Fri, 1 Jun 2012 20:07:26 -0300 Message-ID: <20120601230726.GA5356@amt.cnet> References: <1337825690.3038.50.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org To: Benjamin Herrenschmidt Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12487 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966037Ab2FAXxI (ORCPT ); Fri, 1 Jun 2012 19:53:08 -0400 Content-Disposition: inline In-Reply-To: <1337825690.3038.50.camel@pasglop> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 24, 2012 at 12:14:50PM +1000, Benjamin Herrenschmidt wrote: > This adds/modifies ifdefs etc. and moves code to make sure that > x86-specific code doesn't get compiled on non-x86 platforms. > These changes all relate to code that is in the qemu-kvm tree and > not in the qemu tree. > > The change from KVM_CAP_IRQCHIP to KVM_IRQCHIP_PIC_MASTER is because > the KVM_CAP_IRQCHIP symbol is defined on all platforms (though the > capability only exists on x86), whereas KVM_IRQCHIP_PIC_MASTER is > only defined on x86. (If a better symbol exists it could be used > instead.) > > Signed-off-by: Benjamin Herrenschmidt Applied, thanks.