From: Gleb Natapov <gleb@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Roedel, Joerg" <joerg.roedel@amd.com>,
Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH 2/2] Provide fast path for "rep ins" emulation if possible.
Date: Tue, 5 Jun 2012 21:17:17 +0300 [thread overview]
Message-ID: <20120605181717.GM20236@redhat.com> (raw)
In-Reply-To: <20120605175016.GJ20236@redhat.com>
On Tue, Jun 05, 2012 at 08:50:16PM +0300, Gleb Natapov wrote:
> > No, what I'm saying is that the hardware omitted some fields even though they were provided in the spec. IIRC it was the size field, but I could be wrong. Please take an old (phenom / barcelona is old enough) machine and create some traces to make 100% sure that all fields you're trying to read out are actually provided.
> >
> May be you are right about missing fields, but I am definitely know that
> this is not the reason string PIO goes through the emulator. Are you
> sure missing fields where on AMD? Intel did miss some crucial info in
> early versions.
>
I double checked and while emulation of string PIO was outside of
emulator the decode went through emulator. The size field should be OK
though since it is used for regular PIO emulation, so may be the problem
was with address size or with effective data segment. If later then this
is well known and does not influence this patch.
--
Gleb.
next prev parent reply other threads:[~2012-06-05 18:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 14:08 [PATCH 0/2] improve speed of "rep ins" emulation Gleb Natapov
2012-05-23 14:08 ` [PATCH 1/2] Provide userspace IO exit completion callback Gleb Natapov
2012-05-23 14:08 ` [PATCH 2/2] Provide fast path for "rep ins" emulation if possible Gleb Natapov
2012-05-23 14:40 ` Avi Kivity
2012-05-23 14:49 ` Avi Kivity
2012-05-24 10:34 ` Roedel, Joerg
2012-05-24 10:36 ` Avi Kivity
2012-05-24 10:54 ` Roedel, Joerg
2012-06-05 17:27 ` Alexander Graf
2012-06-05 17:36 ` Gleb Natapov
2012-06-05 17:41 ` Alexander Graf
2012-06-05 17:50 ` Gleb Natapov
2012-06-05 18:17 ` Gleb Natapov [this message]
2012-06-05 17:57 ` Gleb Natapov
2012-06-06 9:28 ` Roedel, Joerg
2012-06-05 16:07 ` Avi Kivity
2012-06-05 17:19 ` Gleb Natapov
2012-06-06 8:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605181717.GM20236@redhat.com \
--to=gleb@redhat.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox