public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dominic Eschweiler <eschweiler@fias.uni-frankfurt.de>
Cc: "Hans J. Koch" <hjk@hansjkoch.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio_pci_generic does not export memory resources
Date: Fri, 8 Jun 2012 19:39:51 +0300	[thread overview]
Message-ID: <20120608163950.GA3344@redhat.com> (raw)
In-Reply-To: <1339172599.26423.13.camel@tesla>

On Fri, Jun 08, 2012 at 06:23:19PM +0200, Dominic Eschweiler wrote:
> Am Freitag, den 08.06.2012, 17:57 +0200 schrieb Hans J. Koch:
> > What problem do you have with this approach?
> 
> Nothing itself. There is obviously a documentation issue, which really
> confuses people who are new to that stuff. I thought that fixing it, by
> just adding a view lines of code (really a view, when I remove the DMA
> masque part) might enhance this particular module. 
> 
> Anyway, what is wrong when the uio_pci_generic module works like
> described in the related documentation? 

Documentation says this:

	Userspace driver can use pci sysfs interface, or the
	libpci libray that wraps it, to talk to the device and to
	re-enable interrupts by writing to the command register.

maybe we should make the point that *all* interaction with
the device should be done via sysfs, explicit.

> -- 
> Gruß
>   Dominic
> 
> Frankfurt Institute for Advanced Studies (FIAS)
> Ruth-Moufang-Straße 1
> D-60438 Frankfurt am Main
> Germany
> 
> Phone:  +49 (0)

  parent reply	other threads:[~2012-06-08 16:39 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 11:56 [PATCH] uio_pci_generic does not export memory resources Dominic Eschweiler
2012-06-08 13:03 ` Michael S. Tsirkin
2012-06-08 13:16   ` Jan Kiszka
2012-06-08 14:16     ` Alex Williamson
2012-06-08 14:47       ` Dominic Eschweiler
2012-06-08 15:06         ` Alex Williamson
2012-06-08 16:16         ` Andreas Hartmann
2012-06-08 16:41           ` Alex Williamson
2012-06-09  9:28             ` Andreas Hartmann
2012-06-09 14:50               ` Alex Williamson
2012-06-09 16:25                 ` Andreas Hartmann
2012-06-09 16:55                   ` Alex Williamson
2012-06-10  7:21                     ` Andreas Hartmann
2012-06-10 19:12                       ` Andreas Hartmann
2012-06-10 14:12                 ` Michael S. Tsirkin
2012-06-08 16:44           ` Hans J. Koch
2012-06-08 16:59             ` Jan Kiszka
2012-06-08 17:11             ` Alex Williamson
2012-06-10 14:18               ` Michael S. Tsirkin
2012-06-10 16:09                 ` Alex Williamson
2012-06-10 16:44                   ` Michael S. Tsirkin
2012-06-10 17:38                     ` Alex Williamson
2012-06-10 18:43                       ` Michael S. Tsirkin
2012-06-10 19:00                       ` Michael S. Tsirkin
2012-06-10 19:11                         ` Hans J. Koch
2012-06-10 19:16                           ` Michael S. Tsirkin
2012-06-10 20:19                             ` Hans J. Koch
2012-06-10 19:01               ` Hans J. Koch
2012-06-08 14:28   ` Dominic Eschweiler
2012-06-08 15:18     ` Hans J. Koch
2012-06-08 15:45       ` Dominic Eschweiler
2012-06-08 15:57         ` Hans J. Koch
2012-06-08 16:23           ` Dominic Eschweiler
2012-06-08 16:37             ` Hans J. Koch
2012-06-08 17:07               ` Dominic Eschweiler
2012-06-08 17:11                 ` Hans J. Koch
2012-06-08 16:39             ` Michael S. Tsirkin [this message]
2012-06-08 16:07 ` Hans J. Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120608163950.GA3344@redhat.com \
    --to=mst@redhat.com \
    --cc=eschweiler@fias.uni-frankfurt.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hjk@hansjkoch.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox