public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Andreas Hartmann <andihartmann@01019freenet.de>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH] uio_pci_generic does not export memory resources
Date: Sun, 10 Jun 2012 17:12:30 +0300	[thread overview]
Message-ID: <20120610141230.GA8922@redhat.com> (raw)
In-Reply-To: <1339253455.26976.165.camel@ul30vt>

On Sat, Jun 09, 2012 at 08:50:55AM -0600, Alex Williamson wrote:
> > > Hmm, I wonder if we should make a kernel boot parameter that allows
> > > whitelisting some devices.  I think it would have to taint the kernel
> > > but there's probably sufficient interest for usability vs
> > > supportability.
> > 
> > Good idea. I would print an additional big fat warning of dataloss /
> > filesystem damage / crash if this could be the case.
> 
> Well, outlining the risk above makes me a little more nervous about
> making such a config option, even if it taints the kernel, available so
> easily... :^\  Thanks,
> 
> Alex

Yes, please do not do it. Users will use it and we'll have an
unfixable security bug on our hands.

-- 
MST

  parent reply	other threads:[~2012-06-10 14:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 11:56 [PATCH] uio_pci_generic does not export memory resources Dominic Eschweiler
2012-06-08 13:03 ` Michael S. Tsirkin
2012-06-08 13:16   ` Jan Kiszka
2012-06-08 14:16     ` Alex Williamson
2012-06-08 14:47       ` Dominic Eschweiler
2012-06-08 15:06         ` Alex Williamson
2012-06-08 16:16         ` Andreas Hartmann
2012-06-08 16:41           ` Alex Williamson
2012-06-09  9:28             ` Andreas Hartmann
2012-06-09 14:50               ` Alex Williamson
2012-06-09 16:25                 ` Andreas Hartmann
2012-06-09 16:55                   ` Alex Williamson
2012-06-10  7:21                     ` Andreas Hartmann
2012-06-10 19:12                       ` Andreas Hartmann
2012-06-10 14:12                 ` Michael S. Tsirkin [this message]
2012-06-08 16:44           ` Hans J. Koch
2012-06-08 16:59             ` Jan Kiszka
2012-06-08 17:11             ` Alex Williamson
2012-06-10 14:18               ` Michael S. Tsirkin
2012-06-10 16:09                 ` Alex Williamson
2012-06-10 16:44                   ` Michael S. Tsirkin
2012-06-10 17:38                     ` Alex Williamson
2012-06-10 18:43                       ` Michael S. Tsirkin
2012-06-10 19:00                       ` Michael S. Tsirkin
2012-06-10 19:11                         ` Hans J. Koch
2012-06-10 19:16                           ` Michael S. Tsirkin
2012-06-10 20:19                             ` Hans J. Koch
2012-06-10 19:01               ` Hans J. Koch
2012-06-08 14:28   ` Dominic Eschweiler
2012-06-08 15:18     ` Hans J. Koch
2012-06-08 15:45       ` Dominic Eschweiler
2012-06-08 15:57         ` Hans J. Koch
2012-06-08 16:23           ` Dominic Eschweiler
2012-06-08 16:37             ` Hans J. Koch
2012-06-08 17:07               ` Dominic Eschweiler
2012-06-08 17:11                 ` Hans J. Koch
2012-06-08 16:39             ` Michael S. Tsirkin
2012-06-08 16:07 ` Hans J. Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120610141230.GA8922@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=andihartmann@01019freenet.de \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox