From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] uio_pci_generic does not export memory resources Date: Sun, 10 Jun 2012 17:12:30 +0300 Message-ID: <20120610141230.GA8922@redhat.com> References: <1339156616.3870.9.camel@blech> <20120608130351.GB1964@redhat.com> <4FD1FB49.3020905@siemens.com> <1339165009.26976.60.camel@ul30vt> <1339166867.3870.29.camel@blech> <4FD22552.6090609@01019freenet.de> <1339173706.26976.91.camel@ul30vt> <201206090928.q599SXSV003324@mail.maya.org> <1339253455.26976.165.camel@ul30vt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andreas Hartmann , Jan Kiszka , kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22084 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695Ab2FJOMH (ORCPT ); Sun, 10 Jun 2012 10:12:07 -0400 Content-Disposition: inline In-Reply-To: <1339253455.26976.165.camel@ul30vt> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Jun 09, 2012 at 08:50:55AM -0600, Alex Williamson wrote: > > > Hmm, I wonder if we should make a kernel boot parameter that allows > > > whitelisting some devices. I think it would have to taint the kernel > > > but there's probably sufficient interest for usability vs > > > supportability. > > > > Good idea. I would print an additional big fat warning of dataloss / > > filesystem damage / crash if this could be the case. > > Well, outlining the risk above makes me a little more nervous about > making such a config option, even if it taints the kernel, available so > easily... :^\ Thanks, > > Alex Yes, please do not do it. Users will use it and we'll have an unfixable security bug on our hands. -- MST