From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: x86@kernel.org, kvm@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
gleb@redhat.com, Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCHv7 5/8] kvm: eoi msi documentation
Date: Mon, 18 Jun 2012 17:56:26 +0300 [thread overview]
Message-ID: <20120618145626.GF26540@redhat.com> (raw)
In-Reply-To: <4FDF3911.7020902@redhat.com>
On Mon, Jun 18, 2012 at 05:20:01PM +0300, Avi Kivity wrote:
> On 06/14/2012 04:53 PM, Michael S. Tsirkin wrote:
> > Document the new EOI MSR. Couldn't decide whether this change belongs
> > conceptually on guest or host side, so a separate patch.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > Documentation/virtual/kvm/msr.txt | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt
> > index 96b41bd..6ae5a85 100644
> > --- a/Documentation/virtual/kvm/msr.txt
> > +++ b/Documentation/virtual/kvm/msr.txt
> > @@ -223,3 +223,35 @@ MSR_KVM_STEAL_TIME: 0x4b564d03
> > steal: the amount of time in which this vCPU did not run, in
> > nanoseconds. Time during which the vcpu is idle, will not be
> > reported as steal time.
> > +
> > +MSR_KVM_EOI_EN: 0x4b564d04
> > + data: Bit 0 is 1 when PV end of interrupt is enabled on the vcpu; 0
> > + when disabled. When enabled, bits 63-1 hold 2-byte aligned physical address
> > + of a 2 byte memory area which must be in guest RAM and must be zeroed.
>
> 2 byte aligned means we must never access it on the host with a >2 byte
> instruction, or we risk touching unmapped memory.
Yes. So ... that's correct for any length.
The patch actually accesses a single byte only.
Could you clarify what you are saying here please?
> --
> error compiling committee.c: too many arguments to function
>
next prev parent reply other threads:[~2012-06-18 14:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 13:52 [PATCHv7 0/8] kvm: eoi optimization support Michael S. Tsirkin
2012-06-14 13:52 ` [PATCHv7 1/8] kvm: document lapic regs field Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 2/8] kvm: optimize ISR lookups Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 3/8] kvm_para: guest side for eoi avoidance Michael S. Tsirkin
2012-06-18 14:17 ` Avi Kivity
2012-06-18 14:50 ` Michael S. Tsirkin
2012-06-18 15:01 ` Avi Kivity
2012-06-18 17:15 ` Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 4/8] x86/bitops: note on __test_and_clear_bit atomicity Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 5/8] kvm: eoi msi documentation Michael S. Tsirkin
2012-06-18 14:20 ` Avi Kivity
2012-06-18 14:56 ` Michael S. Tsirkin [this message]
2012-06-18 15:03 ` Avi Kivity
2012-06-18 16:01 ` Michael S. Tsirkin
2012-06-18 15:00 ` Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 6/8] kvm: only sync when attention bits set Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 7/8] kvm: rearrange injection cancelling code Michael S. Tsirkin
2012-06-14 13:53 ` [PATCHv7 8/8] kvm: host side for eoi optimization Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618145626.GF26540@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).