From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v8 07/15] ARM: KVM: Hypervisor inititalization Date: Thu, 28 Jun 2012 22:07:07 -0300 Message-ID: <20120629010707.GA12611@amt.cnet> References: <20120615190553.24590.18391.stgit@ubuntu> <20120615190759.24590.74953.stgit@ubuntu> <20120628223551.GD7767@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: android-virt@lists.cs.columbia.edu, kvm@vger.kernel.org To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754303Ab2F2Bp7 (ORCPT ); Thu, 28 Jun 2012 21:45:59 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 28, 2012 at 06:53:43PM -0400, Christoffer Dall wrote: > > should assign per_cpu(kvm_arm_hyp_stack_page, cpu) to NULL. > > > > why? this is run as part of the init code and thus the only way it > could ever run again would be to have the module unloaded in which > case the variable would be re-initialized to zero as per the static > declaration, no? Right.