From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] kvm: Don't abort on kvm_irqchip_add_msi_route()
Date: Fri, 29 Jun 2012 20:02:59 -0300
Message-ID: <20120629230259.GA14304@amt.cnet>
References: <20120625154024.3598.7168.stgit@bling.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: avi@redhat.com, kvm@vger.kernel.org, jan.kiszka@siemens.com,
	qemu-devel@nongnu.org
To: Alex Williamson <alex.williamson@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:63377 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752748Ab2F2Xdf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 29 Jun 2012 19:33:35 -0400
Content-Disposition: inline
In-Reply-To: <20120625154024.3598.7168.stgit@bling.home>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Jun 25, 2012 at 09:40:39AM -0600, Alex Williamson wrote:
> Anyone using these functions has to be prepared that irqchip
> support may not be present.  It shouldn't be up to the core
> code to determine whether this is a fatal error.  Currently
> code written as:
> 
> virq = kvm_irqchip_add_msi_route(...)
> if (virq < 0) {
>     <slow path>
> } else {
>     <fast path>
> }
> 
> works on x86 with and without kvm irqchip enabled, works
> without kvm support compiled in, but aborts() on !x86 with
> kvm support.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Applied to uq/master.