From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: avi@redhat.com, gleb@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, jan.kiszka@siemens.com
Subject: Re: [PATCH v5 1/4] kvm: Extend irqfd to support level interrupts
Date: Wed, 18 Jul 2012 00:26:12 +0300 [thread overview]
Message-ID: <20120717212612.GA2018@redhat.com> (raw)
In-Reply-To: <20120716203344.1752.14606.stgit@bling.home>
On Mon, Jul 16, 2012 at 02:33:47PM -0600, Alex Williamson wrote:
> @@ -96,6 +183,9 @@ irqfd_shutdown(struct work_struct *work)
> * It is now safe to release the object's resources
> */
> eventfd_ctx_put(irqfd->eventfd);
> +
> + _irq_source_put(irqfd->source);
> +
> kfree(irqfd);
> }
>
Hang on, this is a bug I think. This is done asynchronously. So this
means that I can assign MAX number of irqfds, then close one, and now
assign will fail because deassign did not get freed.
Maybe we can solve this by flushing wq before assign?
Looks a bit fragile but may be enough - need to document well.
--
MST
next prev parent reply other threads:[~2012-07-17 21:25 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 20:33 [PATCH v5 0/4] kvm: level irqfd and new eoifd Alex Williamson
2012-07-16 20:33 ` [PATCH v5 1/4] kvm: Extend irqfd to support level interrupts Alex Williamson
2012-07-17 21:26 ` Michael S. Tsirkin [this message]
2012-07-17 21:57 ` Alex Williamson
2012-07-17 22:00 ` Michael S. Tsirkin
2012-07-17 22:16 ` Alex Williamson
2012-07-17 22:28 ` Michael S. Tsirkin
2012-07-18 10:41 ` Michael S. Tsirkin
2012-07-18 10:44 ` Gleb Natapov
2012-07-18 10:48 ` Michael S. Tsirkin
2012-07-18 10:49 ` Gleb Natapov
2012-07-18 10:53 ` Michael S. Tsirkin
2012-07-18 10:55 ` Gleb Natapov
2012-07-18 11:22 ` Michael S. Tsirkin
2012-07-18 11:39 ` Michael S. Tsirkin
2012-07-18 11:48 ` Gleb Natapov
2012-07-18 12:07 ` Michael S. Tsirkin
2012-07-18 14:47 ` Alex Williamson
2012-07-18 15:38 ` Michael S. Tsirkin
2012-07-18 15:48 ` Alex Williamson
2012-07-18 15:58 ` Michael S. Tsirkin
2012-07-18 18:42 ` Marcelo Tosatti
2012-07-18 19:00 ` Gleb Natapov
2012-07-18 19:07 ` Alex Williamson
2012-07-18 19:13 ` Alex Williamson
2012-07-18 19:16 ` Michael S. Tsirkin
2012-07-18 20:28 ` Alex Williamson
2012-07-18 21:23 ` Marcelo Tosatti
2012-07-18 21:30 ` Michael S. Tsirkin
2012-07-16 20:33 ` [PATCH v5 2/4] kvm: KVM_EOIFD, an eventfd for EOIs Alex Williamson
2012-07-17 10:21 ` Michael S. Tsirkin
2012-07-17 13:59 ` Alex Williamson
2012-07-17 14:10 ` Michael S. Tsirkin
2012-07-17 14:29 ` Alex Williamson
2012-07-17 14:42 ` Michael S. Tsirkin
2012-07-17 14:57 ` Alex Williamson
2012-07-17 15:13 ` Michael S. Tsirkin
2012-07-17 15:41 ` Alex Williamson
2012-07-17 15:53 ` Michael S. Tsirkin
2012-07-17 16:06 ` Alex Williamson
2012-07-17 16:19 ` Michael S. Tsirkin
2012-07-17 16:52 ` Alex Williamson
2012-07-17 18:58 ` Michael S. Tsirkin
2012-07-17 20:03 ` Alex Williamson
2012-07-17 21:23 ` Michael S. Tsirkin
2012-07-17 22:09 ` Alex Williamson
2012-07-17 22:24 ` Michael S. Tsirkin
2012-07-18 2:44 ` Alex Williamson
2012-07-18 10:31 ` Michael S. Tsirkin
2012-07-16 20:34 ` [PATCH v5 3/4] kvm: Create kvm_clear_irq() Alex Williamson
2012-07-17 0:51 ` Michael S. Tsirkin
2012-07-17 2:42 ` Alex Williamson
2012-07-17 0:55 ` Michael S. Tsirkin
2012-07-17 10:14 ` Michael S. Tsirkin
2012-07-17 13:56 ` Alex Williamson
2012-07-17 14:08 ` Michael S. Tsirkin
2012-07-17 14:21 ` Alex Williamson
2012-07-17 14:53 ` Michael S. Tsirkin
2012-07-17 15:20 ` Alex Williamson
2012-07-17 15:36 ` Michael S. Tsirkin
2012-07-17 15:51 ` Alex Williamson
2012-07-17 15:57 ` Michael S. Tsirkin
2012-07-17 16:01 ` Gleb Natapov
2012-07-17 16:08 ` Alex Williamson
2012-07-17 16:14 ` Michael S. Tsirkin
2012-07-17 16:17 ` Alex Williamson
2012-07-17 16:21 ` Michael S. Tsirkin
2012-07-17 16:45 ` Alex Williamson
2012-07-17 18:55 ` Michael S. Tsirkin
2012-07-17 19:51 ` Alex Williamson
2012-07-17 21:05 ` Michael S. Tsirkin
2012-07-17 22:01 ` Alex Williamson
2012-07-17 22:05 ` Michael S. Tsirkin
2012-07-17 22:22 ` Alex Williamson
2012-07-17 22:31 ` Michael S. Tsirkin
2012-07-18 6:27 ` Gleb Natapov
2012-07-18 10:20 ` Michael S. Tsirkin
2012-07-18 10:27 ` Gleb Natapov
2012-07-18 10:33 ` Michael S. Tsirkin
2012-07-18 10:36 ` Gleb Natapov
2012-07-18 10:51 ` Michael S. Tsirkin
2012-07-18 10:53 ` Gleb Natapov
2012-07-18 11:08 ` Michael S. Tsirkin
2012-07-18 11:50 ` Gleb Natapov
2012-07-18 21:55 ` Michael S. Tsirkin
2012-07-17 16:36 ` Michael S. Tsirkin
2012-07-17 17:09 ` Gleb Natapov
2012-07-17 10:18 ` Michael S. Tsirkin
2012-07-16 20:34 ` [PATCH v5 4/4] kvm: Convert eoifd to use kvm_clear_irq Alex Williamson
2012-07-18 10:43 ` [PATCH v5 0/4] kvm: level irqfd and new eoifd Michael S. Tsirkin
2012-07-19 16:59 ` Michael S. Tsirkin
2012-07-19 17:29 ` Alex Williamson
2012-07-19 17:45 ` Michael S. Tsirkin
2012-07-19 18:48 ` Alex Williamson
2012-07-20 10:07 ` Michael S. Tsirkin
2012-07-22 15:09 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717212612.GA2018@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).