From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [RFC PATCH 3/3] KVM: Push rmap into kvm_arch_memory_slot Date: Fri, 3 Aug 2012 09:59:15 +1000 Message-ID: <20120802235915.GA12559@bloggs.ozlabs.ibm.com> References: <20120801175954.ea4c434b.yoshikawa.takuya@oss.ntt.co.jp> <20120801180328.d5b48ef3.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, mtosatti@redhat.com, agraf@suse.de, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Takuya Yoshikawa Return-path: Content-Disposition: inline In-Reply-To: <20120801180328.d5b48ef3.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Aug 01, 2012 at 06:03:28PM +0900, Takuya Yoshikawa wrote: > Two reasons: > - x86 can integrate rmap and rmap_pde and remove heuristics in > __gfn_to_rmap(). > - Some architectures do not need rmap. > > Since rmap is one of the most memory consuming stuff in KVM, ppc'd > better restrict the allocation to Book3S HV. > > Signed-off-by: Takuya Yoshikawa > Cc: Paul Mackerras Looks like a worthwhile change. I do have some patches in preparation that will intersect with this, but I can manage that once these patches go upstream. Acked-by: Paul Mackerras