From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Hartmann Subject: Re: [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2 Date: Mon, 13 Aug 2012 17:48:34 +0200 Message-ID: <20120813174834.7f4346c7@dualc.maya.org> References: <20120801050241.22163.78549.stgit@bling.home> <87pq6uvs52.fsf@codemonkey.ws> <1344867810.4683.21.camel@ul30vt.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, aik@ozlabs.ru, Jan Kiszka , Benjamin Herrenschmidt , Avi Kivity , Blue Swirl To: Alex Williamson Return-path: Received: from mout2.freenet.de ([195.4.92.92]:44120 "EHLO mout2.freenet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971Ab2HMQJE (ORCPT ); Mon, 13 Aug 2012 12:09:04 -0400 In-Reply-To: <1344867810.4683.21.camel@ul30vt.home> Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > On Mon, 2012-08-13 at 08:27 -0500, Anthony Liguori wrote: >> Alex Williamson writes: >> >>> VFIO kernel support was just merged into Linux, so I'd like to >>> formally propose inclusion of the QEMU vfio-pci driver for >>> QEMU 1.2. Included here is support for x86 PCI device assignment. >>> PCI INTx is not yet enabled, but devices making use of either MSI >>> or MSI-X work. The level irqfd and eoifd support I've proposed >>> for KVM enable an accelerated patch for this through KVM. I'd >>> like to get this base driver in first and enable the remaining >>> support in-tree. >>> >>> I've split this version up a little from the RFC to make it a bit >>> easier to review. Review comments from Blue Swirl and Avi are >>> already incorporated, including Avi's requests to simplify both >>> the PCI BAR mapping and unmapping paths. >> >> Hi Alex, >> >> Thanks for pushing this forward! Hopefully this will finally kill >> off qemu-kvm.git for good. >> >> I think this series is going to have to wait for 1.3 to open up. We >> have a very short release window for this release and I'd feel a lot >> more comfortable having such a significant feature spend some time in >> the development cycle getting testing/review. >> >> I'd like to see a few Reviewed-by's too for this series before it >> goes in. I expect they won't be hard to get but I also expect it >> will take a few more revisions of this series to get there. > > That's disappointing, but I can understand your reluctance. Blue > Swirl reviewed the RFC and could perhaps add a Reviewed-by. Alexey > has been working on the POWER port and I'm sure could provide a > Reviewed-by. We also have a few early adopters that are already > making use of this code. I'm running qemu with vfio patch since Jun 05, 2012 (awilliam-qemu-vfio-v0.14.0-rc0-6402-g323cf9f.tar.gz). I didn't encounter any problem so far. If you like, I could compile a more actual version, too (if there have been any changes). To see more about my use case: http://permalink.gmane.org/gmane.linux.drivers.rt2x00.user/1051 You may add a Tested-by Andreas Hartmann if you like. Unfortunately, I'm only running the vfio VM (kvm) with this version of qemu, but I'm running parallel 4 other VM's with the unchanged version of qemu (kvm-0.15.0-123.2.x86_64), too. One of these 4 VM's uses PCIe passthrough. I now tried to run all VMs with the new version of qemu. At this point, I unfortunately run into a problem with the VM which passes through a PCIe device. The error message is (during start of VM): virsh start VM error: Failed to start domain VM error: internal error process exited while connecting to monitor: qemu-system-x86_64: -device pci-assign,host=04:00.0,id=hostdev0,bus=pci.0,addr=0x6: Parameter 'driver' expects device type The xml file for libvirt looks like this: VM 44444444-4444-2222-7777-111111111111 1048576 262144 1 hvm destroy restart destroy /usr/local/bin/qemu-system-x86_64
Maybe, this is fixed in a newer version of qemu for vfio? Thanks, kind regards, Andreas Hartmann