From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 3.6] KVM: x86 emulator: use stack size attribute to mask rsp in stack ops
Date: Wed, 22 Aug 2012 18:55:08 -0300 [thread overview]
Message-ID: <20120822215508.GA30167@amt.cnet> (raw)
In-Reply-To: <1345376071-27965-1-git-send-email-avi@redhat.com>
On Sun, Aug 19, 2012 at 02:34:31PM +0300, Avi Kivity wrote:
> The sub-register used to access the stack (sp, esp, or rsp) is not
> determined by the address size attribute like other memory references,
> but by the stack segment's B bit (if not in x86_64 mode).
>
> Fix by using the existing stack_mask() to figure out the correct mask.
>
> This long-existing bug was exposed by a combination of a27685c33acccce
> (emulate invalid guest state by default), which causes many more
> instructions to be emulated, and a seabios change (possibly a bug) which
> causes the high 16 bits of esp to become polluted across calls to real
> mode software interrupts.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2012-08-23 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 11:34 [PATCH 3.6] KVM: x86 emulator: use stack size attribute to mask rsp in stack ops Avi Kivity
2012-08-22 21:55 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822215508.GA30167@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox