From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: [patch 2/3] KVM: perform an invalid memslot step for gpa base change Date: Fri, 24 Aug 2012 15:54:58 -0300 Message-ID: <20120824185634.562101569@amt.cnet> References: <20120824185456.658814016@amt.cnet> Cc: Xiao Guangrong , kvm@vger.kernel.org, Marcelo Tosatti To: Paul Mackerras , Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44479 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148Ab2HXS6M (ORCPT ); Fri, 24 Aug 2012 14:58:12 -0400 Content-Disposition: inline; filename=02-invalidate-translations-on-memslot-gpa-change Sender: kvm-owner@vger.kernel.org List-ID: PPC must flush all translations before the new memory slot is visible. Signed-off-by: Marcelo Tosatti Index: kvm/virt/kvm/kvm_main.c =================================================================== --- kvm.orig/virt/kvm/kvm_main.c +++ kvm/virt/kvm/kvm_main.c @@ -791,7 +791,7 @@ int __kvm_set_memory_region(struct kvm * /* destroy any largepage mappings for dirty tracking */ } - if (!npages) { + if (!npages || base_gfn != old.base_gfn) { struct kvm_memory_slot *slot; r = -ENOMEM; @@ -807,8 +807,8 @@ int __kvm_set_memory_region(struct kvm * old_memslots = kvm->memslots; rcu_assign_pointer(kvm->memslots, slots); synchronize_srcu_expedited(&kvm->srcu); - /* From this point no new shadow pages pointing to a deleted - * memslot will be created. + /* From this point no new shadow pages pointing to a deleted, + * or moved, memslot will be created. * * validation of sp->gfn happens in: * - gfn_to_hva (kvm_read_guest, gfn_to_pfn)