From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] kvm/book3s: fix build error caused by gfn_to_hva_memslot() Date: Mon, 27 Aug 2012 16:52:55 -0300 Message-ID: <20120827195255.GA30661@amt.cnet> References: <1345798228-30966-1-git-send-email-shangw@linux.vnet.ibm.com> <20120824090314.GB7051@bloggs.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com, xiaoguangrong@linux.vnet.ibm.com To: Paul Mackerras , Gavin Shan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55337 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643Ab2H0Uyc (ORCPT ); Mon, 27 Aug 2012 16:54:32 -0400 Content-Disposition: inline In-Reply-To: <20120824090314.GB7051@bloggs.ozlabs.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Aug 24, 2012 at 07:03:14PM +1000, Paul Mackerras wrote: > On Fri, Aug 24, 2012 at 04:50:28PM +0800, Gavin Shan wrote: > > The build error was caused by that builtin functions are calling > > the functions implemented in modules. That was introduced by the > > following commit. > > > > commit 4d8b81abc47b83a1939e59df2fdb0e98dfe0eedd > > > > The patch fixes the build error by moving function __gfn_to_hva_memslot() > > from kvm_main.c to kvm_host.h and making that "inline" so that the > > builtin function (kvmppc_h_enter) can use that. > > > > Signed-off-by: Gavin Shan > > Acked-by: Paul Mackerras > > By the way, when you give a commit ID it's a good idea to give the > headline of the commit as well, something like this: > > This error was introduced by commit 4d8b81abc4 ("KVM: introduce > readonly memslot"). > > Paul. Applied, thanks (with suggested changelog modification).