Re: [PATCH RFC 1/2] KVM: PPC: Move kvm->arch.slot_phys into memslot.arch

[Marcelo Tosatti <mtosatti@redhat.com>]

On Sat, Aug 25, 2012 at 10:40:40PM +1000, Paul Mackerras wrote:
> Now that we have an architecture-specific field in the kvm_memory_slot
> structure, we can use it to store the array of page physical addresses
> that we need for Book3S HV KVM on PPC970 processors.  This reduces the
> size of struct kvm_arch for Book3S HV, and also reduces the size of
> struct kvm_arch_memory_slot for other PPC KVM variants since the fields
> in it are now only compiled in for Book3S HV.
> 
> This necessitates making the kvm_arch_create_memslot and
> kvm_arch_free_memslot operations specific to each PPC KVM variant.
> That in turn means that we now don't allocate the rmap arrays on
> Book3S PR and Book E.
> 
> Since we now unpin pages and free the slot_phys array in
> kvmppc_core_free_memslot, we no longer need to do it in
> kvmppc_core_destroy_vm, since the generic code takes care to free
> all the memslots when destroying a VM.
> 
> We now need the new memslot to be passed in to
> kvmppc_core_prepare_memory_region, since we need to initialize its
> arch.slot_phys member on Book3S HV.
> 
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> This is on top of Alex's kvm-ppc-next branch with the KVM tree's next
> branch merged in and then Marcelo's set of 3 patches on that.
> 
>  arch/powerpc/include/asm/kvm_host.h |    9 +--
>  arch/powerpc/include/asm/kvm_ppc.h  |    5 ++
>  arch/powerpc/kvm/book3s_64_mmu_hv.c |    6 +-
>  arch/powerpc/kvm/book3s_hv.c        |  104 ++++++++++++++++++++---------------
>  arch/powerpc/kvm/book3s_hv_rm_mmu.c |    2 +-
>  arch/powerpc/kvm/book3s_pr.c        |   12 ++++
>  arch/powerpc/kvm/booke.c            |   12 ++++
>  arch/powerpc/kvm/powerpc.c          |   13 +----
>  8 files changed, 102 insertions(+), 61 deletions(-)

Regarding generic memslot code, looks fine.