From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
Date: Thu, 6 Sep 2012 11:49:17 +0300
Message-ID: <20120906084917.GG17656@redhat.com>
References: <cover.1346048917.git.jan.kiszka@web.de>
 <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de>
 <503CA542.7030707@siemens.com>
 <503FB128.4070709@siemens.com>
 <5048625F.2060706@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Blue Swirl <blauwirbel@gmail.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
	Peter Maydell <peter.maydell@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58118 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751965Ab2IFIsD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 6 Sep 2012 04:48:03 -0400
Content-Disposition: inline
In-Reply-To: <5048625F.2060706@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Sep 06, 2012 at 10:44:15AM +0200, Jan Kiszka wrote:
> On 2012-08-30 20:30, Jan Kiszka wrote:
> > This adds PCI device assignment for i386 targets using the classic KVM
> > interfaces. This version is 100% identical to what is being maintained
> > in qemu-kvm for several years and is supported by libvirt as well. It is
> > expected to remain relevant for another couple of years until kernels
> > without full-features and performance-wise equivalent VFIO support are
> > obsolete.
> > 
> > A refactoring to-do that should be done in-tree is to model MSI and
> > MSI-X support via the generic PCI layer, similar to what VFIO is already
> > doing for MSI-X. This should improve the correctness and clean up the
> > code from duplicate logic.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > 
> > Changes in v3:
> >  - addressed comment by Peter (changed device name to kvm-pci-assign +
> >    alias)
> >  - addressed (most) comments by Michael
> >  - fixed INT pin regression
> 
> Does someone _disagree_ that there are no open (and reasonably solvable)
> issues and that this can now be merged through uq/master?
> 
> Jan

Ugh this thread was shamelessly highjacked by coding style
bike-shedding. I am guilty to.
In hopes of making amends:

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> -- 
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux