From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class() Date: Fri, 7 Sep 2012 18:59:27 -0700 Message-ID: <20120908015927.GA29784@kroah.com> References: <20120731235705.GW2422@linux.vnet.ibm.com> <1343779778.27983.73.camel@gandalf.stny.rr.com> <20120801001811.GX2422@linux.vnet.ibm.com> <20120801004319.GA7043@localhost> <20120822025008.GA8066@localhost> <20120822154908.2e6ef3c0@feng-i7> <20120823154503.15a45b14@feng-i7> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Fengguang Wu , "Paul E. McKenney" , Steven Rostedt , Avi Kivity , Steven Rostedt , LKML , "kvm@vger.kernel.org" , Kenji Kaneshige , linux-pci@vger.kernel.org, Feng Tang , Bjorn Helgaas To: Yinghai Lu Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > Greg, > > Any reason for using kmalloc instead of local variable during your > rewriting pci search code? > > commit 95247b57ed844511a212265b45cf9a919753aea1 > Author: Greg Kroah-Hartman > Date: Wed Feb 13 11:03:58 2008 -0800 Seriously? Something I wrote 4 years ago? I really have no idea, sorry. greg k-h