Re: [RFC PATCH] KVM: optimize apic interrupt delivery

[Gleb Natapov <gleb@redhat.com>]

On Mon, Sep 10, 2012 at 07:17:54PM +0300, Gleb Natapov wrote:
> > > +	return 0;
> > > +}
> > > +
> > > +static inline int kvm_apic_set_id(struct kvm_lapic *apic, u8 id)
> > > +{
> > > +	apic_set_reg(apic, APIC_ID, id << 24);
> > > +	return recalculate_apic_map(apic->vcpu->kvm);
> > > +}
> > > +
> > > +static inline int kvm_apic_set_ldr(struct kvm_lapic *apic, u32 id)
> > > +{
> > > +	apic_set_reg(apic, APIC_LDR, id);
> > > +	return recalculate_apic_map(apic->vcpu->kvm);
> > > +}
> > > +
> > 
> > return value of these functions seems never checked.
> > 
> Yes, the problem is that we can do nothing about the failure if failure
> happens during guest write.
> 
Actually I have an idea how to handle the error. Never return one. If
map cannot be allocated go slow path always. phys_map should be checked
for NULL during delivery in this case obviously.

--
			Gleb.