From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: PPC: Book3S: Implement floating-point state get/set functions
Date: Fri, 14 Sep 2012 11:36:37 +1000 [thread overview]
Message-ID: <20120914013636.GA31335@drongo> (raw)
In-Reply-To: <9E858BF2-180D-48D3-AD0D-89ACB9436554@suse.de>
On Fri, Sep 14, 2012 at 02:03:15AM +0200, Alexander Graf wrote:
>
> Yup, Considering how different the FPU state on differnet ppc cores is, I'd be more happy with shoving it into something that allows for more dynamic control. Otherwise we'd end up with yet another struct sregs that can contain SPE registers, altivec, and a dozen additions to it :).
>
> Please just use one_reg for all of the register synchronization you want to add, unless there's a compelling reason to do it differently. It will make our live a lot easier in the future. If we need to transfer too much data and actually run into performance trouble, we can always add a GET_MANY_REG ioctl.
It just seems perverse to ignore the existing interface that every
other architecture uses, and instead do something unique that is
actually slower, but whatever...
Paul.
next prev parent reply other threads:[~2012-09-14 1:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 0:17 [PATCH 0/2] KVM: PPC: Save/restore complete Book3S HV guest register state Paul Mackerras
2012-09-12 0:18 ` [PATCH 1/2] KVM: PPC: Book3S HV: Get/set guest SPRs using the GET/SET_ONE_REG interface Paul Mackerras
2012-09-13 23:29 ` Alexander Graf
2012-09-12 0:19 ` [PATCH 2/2] KVM: PPC: Book3S: Implement floating-point state get/set functions Paul Mackerras
2012-09-13 23:30 ` Alexander Graf
2012-09-13 23:58 ` Paul Mackerras
2012-09-14 0:03 ` Alexander Graf
2012-09-14 1:36 ` Paul Mackerras [this message]
2012-09-14 1:44 ` Alexander Graf
2012-09-14 1:50 ` Alexander Graf
2012-09-14 7:15 ` Paul Mackerras
2012-09-19 3:37 ` Benjamin Herrenschmidt
2012-09-19 8:45 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914013636.GA31335@drongo \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox