* [PATCH] KVM: Move some PPC ioctl definitions to the correct place
@ 2012-09-14 7:44 Paul Mackerras
2012-09-14 14:19 ` Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Paul Mackerras @ 2012-09-14 7:44 UTC (permalink / raw)
To: Avi Kivity, Alexander Graf; +Cc: kvm-ppc, kvm
This moves the definitions of KVM_CREATE_SPAPR_TCE and
KVM_ALLOCATE_RMA in include/linux/kvm.h from the section listing the
vcpu ioctls to the section listing VM ioctls, as these are both
implemented and documented as VM ioctls.
Fortunately there is no actual collision of ioctl numbers at this
point. Moving these to the correct section will reduce the
probability of a future collision. This does not change the
user/kernel ABI at all.
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
I just noticed this. This patch is against the next branch of the
kvm tree. It would be good to get this applied to next as soon as
possible so no-one else allocates these VM ioctl numbers.
Documentation/virtual/kvm/api.txt has these correctly listed as
VM ioctls.
include/linux/kvm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/kvm.h b/include/linux/kvm.h
index d808694..acb6333 100644
--- a/include/linux/kvm.h
+++ b/include/linux/kvm.h
@@ -838,6 +838,9 @@ struct kvm_s390_ucas_mapping {
#define KVM_PPC_GET_SMMU_INFO _IOR(KVMIO, 0xa6, struct kvm_ppc_smmu_info)
/* Available with KVM_CAP_PPC_ALLOC_HTAB */
#define KVM_PPC_ALLOCATE_HTAB _IOWR(KVMIO, 0xa7, __u32)
+#define KVM_CREATE_SPAPR_TCE _IOW(KVMIO, 0xa8, struct kvm_create_spapr_tce)
+/* Available with KVM_CAP_RMA */
+#define KVM_ALLOCATE_RMA _IOR(KVMIO, 0xa9, struct kvm_allocate_rma)
/*
* ioctls for vcpu fds
@@ -901,9 +904,6 @@ struct kvm_s390_ucas_mapping {
/* Available with KVM_CAP_XCRS */
#define KVM_GET_XCRS _IOR(KVMIO, 0xa6, struct kvm_xcrs)
#define KVM_SET_XCRS _IOW(KVMIO, 0xa7, struct kvm_xcrs)
-#define KVM_CREATE_SPAPR_TCE _IOW(KVMIO, 0xa8, struct kvm_create_spapr_tce)
-/* Available with KVM_CAP_RMA */
-#define KVM_ALLOCATE_RMA _IOR(KVMIO, 0xa9, struct kvm_allocate_rma)
/* Available with KVM_CAP_SW_TLB */
#define KVM_DIRTY_TLB _IOW(KVMIO, 0xaa, struct kvm_dirty_tlb)
/* Available with KVM_CAP_ONE_REG */
--
1.7.10.rc3.219.g53414
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: Move some PPC ioctl definitions to the correct place
2012-09-14 7:44 [PATCH] KVM: Move some PPC ioctl definitions to the correct place Paul Mackerras
@ 2012-09-14 14:19 ` Alexander Graf
2012-09-15 15:40 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2012-09-14 14:19 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Avi Kivity, kvm-ppc, KVM list, Marcelo Tosatti
On 14.09.2012, at 09:44, Paul Mackerras wrote:
> This moves the definitions of KVM_CREATE_SPAPR_TCE and
> KVM_ALLOCATE_RMA in include/linux/kvm.h from the section listing the
> vcpu ioctls to the section listing VM ioctls, as these are both
> implemented and documented as VM ioctls.
>
> Fortunately there is no actual collision of ioctl numbers at this
> point. Moving these to the correct section will reduce the
> probability of a future collision. This does not change the
> user/kernel ABI at all.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Alexander Graf <agraf@suse.de>
Avi / Marcelo, please pull this in directly.
Alex
> ---
> I just noticed this. This patch is against the next branch of the
> kvm tree. It would be good to get this applied to next as soon as
> possible so no-one else allocates these VM ioctl numbers.
> Documentation/virtual/kvm/api.txt has these correctly listed as
> VM ioctls.
>
> include/linux/kvm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index d808694..acb6333 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -838,6 +838,9 @@ struct kvm_s390_ucas_mapping {
> #define KVM_PPC_GET_SMMU_INFO _IOR(KVMIO, 0xa6, struct kvm_ppc_smmu_info)
> /* Available with KVM_CAP_PPC_ALLOC_HTAB */
> #define KVM_PPC_ALLOCATE_HTAB _IOWR(KVMIO, 0xa7, __u32)
> +#define KVM_CREATE_SPAPR_TCE _IOW(KVMIO, 0xa8, struct kvm_create_spapr_tce)
> +/* Available with KVM_CAP_RMA */
> +#define KVM_ALLOCATE_RMA _IOR(KVMIO, 0xa9, struct kvm_allocate_rma)
>
> /*
> * ioctls for vcpu fds
> @@ -901,9 +904,6 @@ struct kvm_s390_ucas_mapping {
> /* Available with KVM_CAP_XCRS */
> #define KVM_GET_XCRS _IOR(KVMIO, 0xa6, struct kvm_xcrs)
> #define KVM_SET_XCRS _IOW(KVMIO, 0xa7, struct kvm_xcrs)
> -#define KVM_CREATE_SPAPR_TCE _IOW(KVMIO, 0xa8, struct kvm_create_spapr_tce)
> -/* Available with KVM_CAP_RMA */
> -#define KVM_ALLOCATE_RMA _IOR(KVMIO, 0xa9, struct kvm_allocate_rma)
> /* Available with KVM_CAP_SW_TLB */
> #define KVM_DIRTY_TLB _IOW(KVMIO, 0xaa, struct kvm_dirty_tlb)
> /* Available with KVM_CAP_ONE_REG */
> --
> 1.7.10.rc3.219.g53414
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: Move some PPC ioctl definitions to the correct place
2012-09-14 14:19 ` Alexander Graf
@ 2012-09-15 15:40 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2012-09-15 15:40 UTC (permalink / raw)
To: Alexander Graf; +Cc: Paul Mackerras, Avi Kivity, kvm-ppc, KVM list
On Fri, Sep 14, 2012 at 04:19:29PM +0200, Alexander Graf wrote:
>
> On 14.09.2012, at 09:44, Paul Mackerras wrote:
>
> > This moves the definitions of KVM_CREATE_SPAPR_TCE and
> > KVM_ALLOCATE_RMA in include/linux/kvm.h from the section listing the
> > vcpu ioctls to the section listing VM ioctls, as these are both
> > implemented and documented as VM ioctls.
> >
> > Fortunately there is no actual collision of ioctl numbers at this
> > point. Moving these to the correct section will reduce the
> > probability of a future collision. This does not change the
> > user/kernel ABI at all.
> >
> > Signed-off-by: Paul Mackerras <paulus@samba.org>
>
> Acked-by: Alexander Graf <agraf@suse.de>
>
>
> Avi / Marcelo, please pull this in directly.
>
> Alex
Can you please bounce it to me? I deleted on the basis it would be
integrated through kvm-ppc tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-15 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 7:44 [PATCH] KVM: Move some PPC ioctl definitions to the correct place Paul Mackerras
2012-09-14 14:19 ` Alexander Graf
2012-09-15 15:40 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox