Re: [PATCH 1/2] KVM: PPC: e500: fix allocation size error on g2h_tlb1_map

[Marcelo Tosatti <mtosatti@redhat.com>]

On Tue, Sep 25, 2012 at 09:46:01AM +0200, Alexander Graf wrote:
> 
> On 23.08.2012, at 03:04, Scott Wood wrote:
> 
> > We were only allocating half the bytes we need, which was made more
> > obvious by a recent fix to the memset in  clear_tlb1_bitmap().
> > 
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
> 
> Thanks, applied to kvm-ppc-next.
> 
> Avi, Marcelo, this one should get applied to anything currently -stable as it essentially means we could overrun an array that has been allocated too small. How do we do this?
> 
> 
> Alex

Apparently Avi prefers that patches are sent directly to the -stable
tree.

Avi?

> 
> > ---
> > arch/powerpc/kvm/e500_tlb.c |    2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/powerpc/kvm/e500_tlb.c b/arch/powerpc/kvm/e500_tlb.c
> > index 43489a8..a27d134 100644
> > --- a/arch/powerpc/kvm/e500_tlb.c
> > +++ b/arch/powerpc/kvm/e500_tlb.c
> > @@ -1385,7 +1385,7 @@ int kvmppc_e500_tlb_init(struct kvmppc_vcpu_e500 *vcpu_e500)
> > 	if (!vcpu_e500->gtlb_priv[1])
> > 		goto err;
> > 
> > -	vcpu_e500->g2h_tlb1_map = kzalloc(sizeof(unsigned int) *
> > +	vcpu_e500->g2h_tlb1_map = kzalloc(sizeof(u64) *
> > 					  vcpu_e500->gtlb_params[1].entries,
> > 					  GFP_KERNEL);
> > 	if (!vcpu_e500->g2h_tlb1_map)
> > -- 
> > 1.7.9.5
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html