From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@bugzilla.kernel.org Subject: [Bug 47451] need to re-load driver in guest to make a hot-plug VF work Date: Fri, 28 Sep 2012 06:07:50 +0000 (UTC) Message-ID: <20120928060750.E9B6C11FC39@bugzilla.kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To: kvm@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.19.201]:39968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754Ab2I1GH6 (ORCPT ); Fri, 28 Sep 2012 02:07:58 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C831620383 for ; Fri, 28 Sep 2012 06:07:56 +0000 (UTC) Received: from bugzilla.kernel.org (bugzilla.kernel.org [198.145.19.217]) by mail.kernel.org (Postfix) with ESMTP id F12132037D for ; Fri, 28 Sep 2012 06:07:55 +0000 (UTC) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: https://bugzilla.kernel.org/show_bug.cgi?id=47451 --- Comment #4 from Jay Ren 2012-09-28 06:07:50 --- (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > >Can we narrow down the kvm.git commit range at all? The > > > one provided is over 12k commits covering v3.4-rc3 to v3.5-rc6. Thanks > > I did more testing. > > Do you remember the bug #43328 ( VT-d/SR-IOV totally doesn't work in guest)? > > Just use your fix commit for that bug, I'll meet this hot-plug issue. > > Is there a chance your patch fixed one bug but introduced another one? :) > > > > commit a76beb14123a69ca080f5a5425e28b786d62318d > > Author: Alex Williamson > > Date: Mon Jul 9 10:53:22 2012 -0600 > > > > KVM: Fix device assignment threaded irq handler > > Thanks for the narrowing it down. It looks like perhaps that patch was > ineffective at trying to keep us out of using IRQF_ONESHOT due to > irq_setup_forced_threading() re-enabling it. Does the problem go away if you > change the two calls to request_threaded_irq() in that commit to use > IRQF_NO_THREAD for the flag value in place of 0? No, replacing flag value with 'IRQF_NO_THREAD' can't make PCIe NIC hot-plug work. Can you try with your commit "a76beb14123a6" ? BTW, sometimes, this bug is not so stable. Using '-m 512 -smp 2' option for qemu-kvm commandline to start a RHEL6.x guest will make it very easy to reproduce. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.